[U-Boot] [EXT] Re: [v2] board: ls1028a: Add an empty video hw init function

[Wen He]

> -----Original Message-----
> From: Bin Meng <bmeng.cn at gmail.com>
> Sent: 2019年5月16日 20:15
> To: Wen He <wen.he_1 at nxp.com>; Simon Glass <sjg at chromium.org>; Tom
> Rini <trini at konsulko.com>
> Cc: Prabhakar Kushwaha <prabhakar.kushwaha at nxp.com>; Jagdish Gediya
> <jagdish.gediya at nxp.com>; u-boot at lists.denx.de
> Subject: [EXT] Re: [U-Boot] [v2] board: ls1028a: Add an empty video hw init
> function
> 
> Caution: EXT Email
> 
> On Thu, May 16, 2019 at 2:48 PM Wen He <wen.he_1 at nxp.com> wrote:
> >
> > The video driver causes a link failure when config VIDEO built-in,
> >
> > drivers/video/cfb_console.c:2022: undefined reference to `video_hw_init'
> >
> > Adding an empty video hw init to slove the build issue, now the board
> > does not support display anything on U-boot.
> >
> > Signed-off-by: Wen He <wen.he_1 at nxp.com>
> > ---
> >  board/freescale/ls1028a/ls1028a.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> 
> I should have commented in the v2 patch here. Sorry for the duplication.
> 
> Please stop adding non-DM driver support to any new platforms. We should
> start using DM driver. In this case, use DM_VIDEO.

Thanks for the comments.

Understand, I will send next version for the feature.

Best Regards,
Wen

> 
> Regards,
> Bin