[U-Boot] [PATCH] usb: dwc3: Fix default dr_mode setting

Marek Vasut marex at denx.de
Fri Jun 28 11:24:27 UTC 2019


On 6/28/19 10:00 AM, Jean-Jacques Hiblot wrote:
> 
> On 27/06/2019 18:30, Marek Vasut wrote:
>> On 6/27/19 6:17 PM, Jean-Jacques Hiblot wrote:
>>> On 27/06/2019 18:12, Marek Vasut wrote:
>>>> On 6/27/19 5:53 PM, Jean-Jacques Hiblot wrote:
>>>>> The IS_ENABLED() macro requires the complete CONFIG option
>>>>> including the
>>>>> 'CONFIG_' prefix.
>>>> Use CONFIG_IS_ENABLED to make it work with SPL ?
>>> There is no SPL variant of this variable.
>> Shouldn't there be one ?
> 
> There is already CONFIG_SPL_USB_GADGET to include/exclude gadget support
> from SPL
> 
> Since there is usually only one kind of gadget controller on a SOC, I
> don't think it is a necessary to also have CONFIG_SPL_USB_DWC3_GADGET

JZ4780 has musb and ci-hdrc for example, so that's not true. There are
other SoCs with OHCI and EHCI combination too.

-- 
Best regards,
Marek Vasut


More information about the U-Boot mailing list