[U-Boot] [PATCH 3/4] usb: xhci-dwc3: Add USB2 PHY configuration

[Mark Kettenis]

> From: Marek Vasut <marex at denx.de>
> Date: Sun, 30 Jun 2019 16:31:41 +0200
> 
> On 6/30/19 4:25 PM, Mark Kettenis wrote:
> >> From: Marek Vasut <marex at denx.de>
> >> Date: Sun, 30 Jun 2019 15:36:03 +0200
> >>
> >> On 6/30/19 3:31 PM, Kever Yang wrote:
> >>> Hi Mark,
> >>>
> >>>     I add Marek and Bin Meng for this patch, I'm not sure where
> >>>
> >>> are these phy setting should go.
> >>>
> >>> Thanks,
> >>> - Kever
> >>> On 06/30/2019 12:29 AM, Mark Kettenis wrote:
> >>>> Configure USB2 PHY register based on "phy_type" property and
> >>>> handle all the quirks that are relevant for Rockchip RK3399 SoCs.
> >>
> >> Is this a documented DT property or some ad-hoc U-Boot one ?
> > 
> > Yes, these are all standard Linux DT properties.  See usb/generic.txt
> > for "phy_type", and usb/dwc3.txt for "snps,dis-enblslpm_quirk" and
> > "snps,dis-u2-freeclk-exists-quirk".
> > 
> >> Is this a fix for this release or feature for next ?
> > 
> > Good question.  The series fixes a regression, but that regression was
> > already present in 2019.04 and you can still boot from uSD, eMMC or
> > USB2 without this fixed.
> 
> Do we expect this to break anything ?

I don't.  The DT properties that are being checked are only present
for in the DTs for RK3399 boards, so this shouldn't affect any other
devices.

But while checking for this I noticed that I misspelled one of the
properties, which had a dash in the old U-Boot-specific binding but an
underscore in the official Linux binding.  So I sent out a v2 of the
series.

Cheers,

Mark