[U-Boot] [PATCH v4 06/17] arm: socfpga: agilex: Add system manager support

[Ley Foon Tan]

On Wed, Oct 2, 2019 at 4:27 PM Simon Goldschmidt
<simon.k.r.goldschmidt at gmail.com> wrote:
>
> On Thu, Sep 12, 2019 at 12:11 PM Ley Foon Tan <ley.foon.tan at intel.com> wrote:
> >
> > Add system manager support for Agilex.
> >
> > Signed-off-by: Ley Foon Tan <ley.foon.tan at intel.com>
> >
> > ---
> > v3:
> > - Change include filename to system_manager_soc64.h.
> > - Move to use defines instead of struct.
> >
> > v2:
> > - Include system_manager_s10_agilex_common.h in system_manager_agilex.h
> > ---
> >  arch/arm/mach-socfpga/include/mach/system_manager.h   |  2 ++
> >  .../mach-socfpga/include/mach/system_manager_agilex.h | 11 +++++++++++
> >  2 files changed, 13 insertions(+)
> >  create mode 100644 arch/arm/mach-socfpga/include/mach/system_manager_agilex.h
> >
> > diff --git a/arch/arm/mach-socfpga/include/mach/system_manager.h b/arch/arm/mach-socfpga/include/mach/system_manager.h
> > index 803305eb35..a4a6bbf600 100644
> > --- a/arch/arm/mach-socfpga/include/mach/system_manager.h
> > +++ b/arch/arm/mach-socfpga/include/mach/system_manager.h
> > @@ -10,6 +10,8 @@ extern phys_addr_t socfpga_sysmgr_base;
> >
> >  #if defined(CONFIG_TARGET_SOCFPGA_STRATIX10)
> >  #include <asm/arch/system_manager_s10.h>
> > +#elif defined(CONFIG_TARGET_SOCFPGA_AGILEX)
> > +#include <asm/arch/system_manager_agilex.h>
>
> Same as before: why do we need this nearly empty file?
>
Noted. Will change this.

Regards
Ley Foon
>
> >  #else
> >  #define SYSMGR_ROMCODEGRP_CTRL_WARMRSTCFGPINMUX        BIT(0)
> >  #define SYSMGR_ROMCODEGRP_CTRL_WARMRSTCFGIO    BIT(1)
> > diff --git a/arch/arm/mach-socfpga/include/mach/system_manager_agilex.h b/arch/arm/mach-socfpga/include/mach/system_manager_agilex.h
> > new file mode 100644
> > index 0000000000..cb284114be
> > --- /dev/null
> > +++ b/arch/arm/mach-socfpga/include/mach/system_manager_agilex.h
> > @@ -0,0 +1,11 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +/*
> > + * Copyright (C) 2019 Intel Corporation <www.intel.com>
> > + */
> > +
> > +#ifndef        _SYSTEM_MANAGER_AGILEX_
> > +#define        _SYSTEM_MANAGER_AGILEX_
> > +
> > +#include <asm/arch/system_manager_soc64.h>
> > +
> > +#endif /* _SYSTEM_MANAGER_AGILEX_ */
> > --
> > 2.19.0
> >