[U-Boot] [PATCH v4 04/17] arm: socfpga: agilex: Add reset manager support

[Simon Goldschmidt]

On Wed, Oct 2, 2019 at 11:25 AM Ley Foon Tan <lftan.linux at gmail.com> wrote:
>
> On Wed, Oct 2, 2019 at 4:26 PM Simon Goldschmidt
> <simon.k.r.goldschmidt at gmail.com> wrote:
> >
> > On Thu, Sep 12, 2019 at 12:11 PM Ley Foon Tan <ley.foon.tan at intel.com> wrote:
> > >
> > > Add reset manager support for Agilex.
> > >
> > > Signed-off-by: Ley Foon Tan <ley.foon.tan at intel.com>
> > >
> > > ---
> > > v3:
> > > - Add reset_manager_soc64.h
> > > - Convert to use defines instead of struct.
> > > ---
> > >  arch/arm/mach-socfpga/include/mach/reset_manager.h    |  2 ++
> > >  .../mach-socfpga/include/mach/reset_manager_agilex.h  | 11 +++++++++++
> > >  2 files changed, 13 insertions(+)
> > >  create mode 100644 arch/arm/mach-socfpga/include/mach/reset_manager_agilex.h
> > >
> > > diff --git a/arch/arm/mach-socfpga/include/mach/reset_manager.h b/arch/arm/mach-socfpga/include/mach/reset_manager.h
> > > index a5b6931350..019c518ae4 100644
> > > --- a/arch/arm/mach-socfpga/include/mach/reset_manager.h
> > > +++ b/arch/arm/mach-socfpga/include/mach/reset_manager.h
> > > @@ -45,6 +45,8 @@ void socfpga_per_reset_all(void);
> > >  #include <asm/arch/reset_manager_arria10.h>
> > >  #elif defined(CONFIG_TARGET_SOCFPGA_STRATIX10)
> > >  #include <asm/arch/reset_manager_s10.h>
> > > +#elif defined(CONFIG_TARGET_SOCFPGA_AGILEX)
> > > +#include <asm/arch/reset_manager_agilex.h>
> >
> > Why don't you just include reset_manager_soc64.h here? No need for the
> > additional file.
> Do you mean remove reset_manager_s10.h and reset_manager_agilex.h and
> include reset_manager_soc64.h directly?
> These 2 header files includes reset_manager_soc64.h and don't have
> additional define in them now.

Right, these files could be removed, no? Unless you're planning to add anything
to them soon...

Regards,
Simon

>
> Regards
> Ley Foon
>
> >
> > >  #endif
> > >
> > >  #endif /* _RESET_MANAGER_H_ */
> > > diff --git a/arch/arm/mach-socfpga/include/mach/reset_manager_agilex.h b/arch/arm/mach-socfpga/include/mach/reset_manager_agilex.h
> > > new file mode 100644
> > > index 0000000000..617e06ec06
> > > --- /dev/null
> > > +++ b/arch/arm/mach-socfpga/include/mach/reset_manager_agilex.h
> > > @@ -0,0 +1,11 @@
> > > +/* SPDX-License-Identifier: GPL-2.0 */
> > > +/*
> > > + * Copyright (C) 2019 Intel Corporation <www.intel.com>
> > > + */
> > > +
> > > +#ifndef        _RESET_MANAGER_AGILEX_
> > > +#define        _RESET_MANAGER_AGILEX_
> > > +
> > > +#include <asm/arch/reset_manager_soc64.h>
> > > +
> > > +#endif /* _RESET_MANAGER_AGILEX_ */
> > > --
> > > 2.19.0
> > >