[U-Boot] [PATCH v2 23/38] efi: Move inline functions to unconditional part of header

Bin Meng bmeng.cn at gmail.com
Wed Oct 2 14:07:01 UTC 2019


On Wed, Sep 25, 2019 at 10:13 PM Simon Glass <sjg at chromium.org> wrote:
>
> At present these two functions are defined in efi_loader.h but only if
> CONFIG_EFI_LOADER is enabled. But these are functions that are useful to
> other code, such as that which deals with Intel Handoff Blocks (HOBs).
>
> Move these to the top of the function.
>
> Possibly ascii2unicode() should not be an inline function, since this
> might impact code size.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
> In general it seems to be bad form to include parts of headers
> conditionally.
>
> Changes in v2: None
>
>  include/efi_loader.h | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>

Reviewed-by: Bin Meng <bmeng.cn at gmail.com>


More information about the U-Boot mailing list