[U-Boot] [PATCH 054/126] x86: Add common functions for TDP and perf control

Bin Meng bmeng.cn at gmail.com
Mon Oct 7 12:52:58 UTC 2019


On Mon, Oct 7, 2019 at 12:15 AM Bin Meng <bmeng.cn at gmail.com> wrote:
>
> On Mon, Oct 7, 2019 at 12:09 AM Bin Meng <bmeng.cn at gmail.com> wrote:
> >
> > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass <sjg at chromium.org> wrote:
> > >
> > > These functions are the same on modern Intel CPUs, so use common code to
> > > set them.
> > >
> > > Signed-off-by: Simon Glass <sjg at chromium.org>
> > > ---
> > >
> > >  arch/x86/cpu/broadwell/cpu.c                  |  7 ++----
> > >  arch/x86/cpu/broadwell/cpu_full.c             |  9 -------
> > >  arch/x86/cpu/intel_common/cpu.c               | 20 +++++++++++++++
> > >  arch/x86/cpu/ivybridge/model_206ax.c          | 25 +++++++------------
> > >  arch/x86/cpu/ivybridge/northbridge.c          |  2 +-
> > >  .../include/asm/arch-ivybridge/model_206ax.h  |  2 +-
> > >  arch/x86/include/asm/cpu_common.h             | 18 +++++++++++++
> > >  7 files changed, 51 insertions(+), 32 deletions(-)
> > >
>
> [snip]
>
> > > diff --git a/arch/x86/include/asm/cpu_common.h b/arch/x86/include/asm/cpu_common.h
> > > index 3d093021ae6..e6a2a0eb3e5 100644
> > > --- a/arch/x86/include/asm/cpu_common.h
> > > +++ b/arch/x86/include/asm/cpu_common.h
> > > @@ -1,5 +1,7 @@
> > >  /* SPDX-License-Identifier: GPL-2.0 */
> > >  /*
> > > + * Common code for Intel CPUs
> > > + *
> > >   * Copyright (c) 2016 Google, Inc
> > >   */
> > >
> > > @@ -56,4 +58,20 @@ int cpu_intel_get_info(struct cpu_info *info, int bclk_mz);
> > >   */
> > >  int cpu_configure_thermal_target(struct udevice *dev);
> > >
> > > +/**
> > > + * cpu_set_perf_control() - Set the nominal CPU clock speed
> > > + *
> > > + * This sets the clock speed as a muiltiplier of BCLK
>
> typo: multiplier
>
> > > + *
> > > + * @clk_ratio: Ratio to use
> > > + */
> > > +void cpu_set_perf_control(uint clk_ratio);
> > > +
> > > +/**
> > > + * cpu_config_tdp_levels() - Check for configurable TDP option
> > > + *
> > > + * @return true if the CPU has configurable TDP (Thermal-desgn power)
>
> typo: design
>
> > > + */
> > > +bool cpu_config_tdp_levels(void);
> > > +
> > >  #endif
> > > --
>
> Will fix these typos when applying.

Fixed return value as false, and these typos, and,

applied to u-boot-x86/next, thanks!


More information about the U-Boot mailing list