[U-Boot] [PATCH 2/2] ARM: imx6q_logic: Enable I2C for PMIC functionality

[Adam Ford]

On Wed, Oct 9, 2019 at 10:23 AM Walter Lozano
<walter.lozano at collabora.com> wrote:
>
> Hi Adam
>
> On Tuesday, October 08, 2019 15:31 -03, Adam Ford <aford173 at gmail.com> wrote:
>
> > The pfuze100 is the PMIC connected to the I2C bus.  Currently,
> > the I2C driver is disabled which prevents the PMIC from operating.
> >
> > This patch enables the I2C which also enables the PMIC in U-Boot.
> > This also keeps the PMIC and I2C disabled in SPL due to size
> > constraints of SPL.
>
> I understand the constrain issue, but instead of disabling I2C support on SPL is it possible to enable SPL_OF_PLATDATA and save some space? I haven't test this feature on a real board, but it should reduce SPL size.

I haven't had good luck with OF_PLATDATA when I've tried in the past.
Maybe the drivers are better now, but some of them didn't load and/or
match the names correctly.  The PMIC is pre-programmed to come up to
the correct voltages, so it's not really needed because we're not
going to change the voltages during SPL anyway.

Stefano's IMX branch has a patch to increase the OCRAM to 256K for the
boards that support the i.MX6D/Q.  I am going to push some changes to
the imx6q_logic_defconfig to enable that feature. Once that's done, I
plan to add some other stuff like pinmuxing to remove the board's
C-code. My hope is to re-enable them in SPL once I get the pinmuxing
stuff added in.

adam
>
> > Signed-off-by: Adam Ford <aford173 at gmail.com>
> >
> > diff --git a/configs/imx6q_logic_defconfig b/configs/imx6q_logic_defconfig
> > index ec14b8eaf6..22ecec3be3 100644
> > --- a/configs/imx6q_logic_defconfig
> > +++ b/configs/imx6q_logic_defconfig
> > @@ -22,7 +22,6 @@ CONFIG_SPL_RAW_IMAGE_SUPPORT=y
> >  CONFIG_SPL_SEPARATE_BSS=y
> >  # CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR is not set
> >  CONFIG_SPL_DMA_SUPPORT=y
> > -CONFIG_SPL_I2C_SUPPORT=y
> >  CONFIG_SPL_NAND_SUPPORT=y
> >  CONFIG_SPL_OS_BOOT=y
> >  CONFIG_SPL_PAYLOAD="u-boot.img"
> > @@ -64,6 +63,7 @@ CONFIG_SPL_DM=y
> >  CONFIG_SPL_DM_SEQ_ALIAS=y
> >  CONFIG_SPL_OF_TRANSLATE=y
> >  CONFIG_PCF8575_GPIO=y
> > +CONFIG_SYS_I2C_MXC=y
> >  CONFIG_LED=y
> >  CONFIG_LED_GPIO=y
> >  CONFIG_FSL_USDHC=y
> > @@ -78,6 +78,7 @@ CONFIG_FEC_MXC=y
> >  CONFIG_MII=y
> >  CONFIG_PINCTRL=y
> >  CONFIG_PINCTRL_IMX6=y
> > +# CONFIG_SPL_PMIC_CHILDREN is not set
> >  CONFIG_DM_PMIC_PFUZE100=y
> >  CONFIG_DM_REGULATOR=y
> >  CONFIG_DM_REGULATOR_PFUZE100=y
> > --
> > 2.17.1
> >
> > _______________________________________________> U-Boot mailing list
> > U-Boot at lists.denx.de
> > https://lists.denx.de/listinfo/u-boot
>
>