[U-Boot] [PATCH v3 3/4] arm: socfpga: Convert system manager from struct to defines

Marek Vasut marex at denx.de
Thu Oct 10 09:39:13 UTC 2019

On 10/10/19 11:29 AM, Anatolij Gustschin wrote:
> On Thu, 10 Oct 2019 10:43:46 +0200
> Simon Goldschmidt simon.k.r.goldschmidt at gmail.com wrote:
> ...
>>> Why is this required? In the past we have rejected all new code adding
>>> defines instead of structs for register accesses. Have we changed our mind now?  
>> Who is we?
> U-Boot maintainers/community.
>> I haven't noticed that in the last 2 years. Plus Linux is rather
>> using structs than defines, or am I wrong?
> The preferred way for I/O access is documented in [1], see "Use structures
> for I/O access" section.

This seems to not scale and I keep running into the problem where a few
registers changed between various mutations of the IP more and more often.

This seems to be the case here too.


More information about the U-Boot mailing list