[U-Boot] [PATCH 000/126] x86: Add initial support for apollolake

[Simon Glass]

Hi Bin,

On Mon, 7 Oct 2019 at 08:31, Bin Meng <bmeng.cn at gmail.com> wrote:
>
> Hi Simon,
>
> On Wed, Oct 2, 2019 at 8:34 PM Bin Meng <bmeng.cn at gmail.com> wrote:
> >
> > Hi Simon,
> >
> > On Wed, Oct 2, 2019 at 10:15 AM Simon Glass <sjg at chromium.org> wrote:
> > >
> > > Hi Bin,
> > >
> > > On Wed, 25 Sep 2019 at 08:58, Simon Glass <sjg at chromium.org> wrote:
> > > >
> > > > Apollolake is an Intel SoC generation aimed at relatively low-end embedded
> > > > systems. It was released in 2016 but has become more popular recently with
> > > > some embedded boards using it.
> > > >
> > > > This series adds support for apollolake. As an example it adds an
> > > > implementation of chromebook_coral (a large range of Chromebooks released
> > > > in 2017).
> > > >
> > > > The series provides only enough to boot to a prompt. It does not include
> > > > display, storage, USB, etc. But it does include the major part of the
> > > > plumbing.
> > > >
> > > > Since this is the first time U-Boot has used FSP2 there is quite a bit of
> > > > refactoring needed. Some of this is in previous series, but much of it is
> > > > here.
> > > >
> > > > Some further clean-up is needed with this series and it needs more
> > > > documentation, but it is ready for review.
> > > >
> > > > This series is available at u-boot-dm/coral-working
> > >
> > > Just a note on this series. I sent it out as it was already getting
> > > huge and I don't like sitting on so many patches.
> > >
> > > I have since done a little more work and have more peripherals running
> > > as well as FSP-S. In doing so I've found some clean-ups in the FSP
> > > parts, moving apollolake-specific code out of the fsp/ directory where
> > > it ended up, for example.
> > >
> > > This results in another 20 patches or so :-(
> > >
> > > The first 45 patches in *this* are not specific to x86 so I am
> > > thinking of dealing with them separately.
> > >
> > > So my plan is:
> > >
> > > 1. Get the sandbox/dm patches reviewed and applied
> > > 2. Tidy up the remaining series
> > > 3. Add the new patches
> > > 4. Resend
> > >
> >
> > Sounds like a good plan.
> >
> > I will start reviewing the patches, and apply the patches as many as
> > possible, to save some efforts of resending such a huge patch series.
> >
>
> I've applied about half of current patches to u-boot-x86/next. I see
> most of them are clean-ups, and preparation for FSP2, and suspect some
> patches may have broader impacts other than sandbox or x86. Hence I am
> going to send a PR soon for what I have for now once the new release
> merge window is open, to leave more time for wider testing. I will
> continue reviewing the remaining patches.
>
> > > I am on holiday for a week so will get to this on the 12th or so.

Thanks for your effort on this. I really appreciate your clean-ups too
and I'm sorry I wasn't able to get things into a better state in time.

I'll take a look through the comments and do a respin. I suspect it
will take me until the 21st but we will see.

Regards,
SImon