[U-Boot] [PATCH] net: eth-uclass: Remove warning about ROM MAC address
Joe Hershberger
joe.hershberger at ni.com
Fri Oct 11 03:06:35 UTC 2019
Hi Soeren,
On Thu, Oct 10, 2019 at 6:01 PM Soeren Moch <smoch at web.de> wrote:
>
> Using a MAC address from ROM storage is the normal case for most
> ethernet hardware. Why should we warn about this?
Most hardware that U-Boot runs on is an SoC and the boards rarely have
a ROM associated with the Ethernet MAC. Usually the storage for the
ethaddr is the U-Boot environment itself. That's the reason it warns.
Cheers,
-Joe
> Signed-off-by: Soeren Moch <smoch at web.de>
> ---
> Cc: Joe Hershberger <joe.hershberger at ni.com>
> Cc: u-boot at lists.denx.de
> ---
> net/eth-uclass.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/net/eth-uclass.c b/net/eth-uclass.c
> index 3bd98b01ad..8b29de37bb 100644
> --- a/net/eth-uclass.c
> +++ b/net/eth-uclass.c
> @@ -538,8 +538,6 @@ static int eth_post_probe(struct udevice *dev)
> memcpy(pdata->enetaddr, env_enetaddr, ARP_HLEN);
> } else if (is_valid_ethaddr(pdata->enetaddr)) {
> eth_env_set_enetaddr_by_index("eth", dev->seq, pdata->enetaddr);
> - printf("\nWarning: %s using MAC address from ROM\n",
> - dev->name);
> } else if (is_zero_ethaddr(pdata->enetaddr) ||
> !is_valid_ethaddr(pdata->enetaddr)) {
> #ifdef CONFIG_NET_RANDOM_ETHADDR
> --
> 2.17.1
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot
More information about the U-Boot
mailing list