[U-Boot] [PATCH 5/5] ARM: MediaTek: add basic support for MT8518 boards
trini at konsulko.com
Fri Oct 11 17:28:48 UTC 2019
On Wed, Sep 11, 2019 at 07:14:59PM +0800, mingming lee wrote:
> This adds a general board file based on MT8518 SoCs from MediaTek.
> Apart from the generic parts (cpu) we add some low level init codes
> and initialize the early clocks.
> This commit is adding the basic boot support for the MT8518 eMMC board.
> Signed-off-by: mingming lee <mingming.lee at mediatek.com>
OK, there's a few problems here:
> +int board_init(void)
> + /* address of boot parameters */
> + gd->bd->bi_boot_params = CONFIG_SYS_SDRAM_BASE + 0x100;
> + printf("gd->fdt_blob is %p\n", gd->fdt_blob);
Please remove this (and audit the series for other) bring-up debug
printfs that we shouldn't need anymore.
> + return 0;
> +int board_late_init(void)
> + /*to load environment variable from persistent store*/
> + gd->env_valid = 1;
> + env_relocate();
> + return 0;
Er, do you really need this?
> +/* Machine ID */
> +#define CONFIG_MACH_TYPE 8518
> +#define CONFIG_SYS_NONCACHED_MEMORY BIT(20)
CONFIG_MACH_TYPE is not relevant to aarch64 platforms (it's for
pre-device tree boards) and 'BIT(20)' isn't a valid value for
CONFIG_SYS_NONCACHED_MEMORY (and leads to a warning a build).
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 833 bytes
Desc: not available
More information about the U-Boot