[U-Boot] [PATCH 2/5] sandbox: Drop 'const' from sandbox_write()

Bin Meng bmeng.cn at gmail.com
Sat Oct 12 02:12:01 UTC 2019


Hi Simon,

On Sat, Oct 12, 2019 at 6:22 AM Simon Glass <sjg at chromium.org> wrote:
>
> This function writes to its address so the address should not be declared
> as const. Fix it.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
>  arch/sandbox/cpu/cpu.c        |  3 +--
>  arch/sandbox/include/asm/io.h | 11 +++++------
>  2 files changed, 6 insertions(+), 8 deletions(-)
>

It looks I did something wrong when testing the previous patch :) I
remember adding const was to fix build warning somewhere else.

Anyway the changes look good to me. But I suspect we need give it a
full build to see whether it generates warning somewhere.

Reviewed-by: Bin Meng <bmeng.cn at gmail.com>


More information about the U-Boot mailing list