[U-Boot] [PATCH 060/126] x86: timer: Set up the timer in timer_early_get_count()

Simon Glass sjg at chromium.org
Sat Oct 12 03:37:57 UTC 2019


Hi Bin,

On Sun, 6 Oct 2019 at 18:32, Bin Meng <bmeng.cn at gmail.com> wrote:
>
> Hi Simon,
>
> On Wed, Sep 25, 2019 at 10:58 PM Simon Glass <sjg at chromium.org> wrote:
> >
> > This function can be called before the timer is set up. Make sure that the
> > init function is called so that it works correctly.
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > ---
> >
> >  drivers/timer/tsc_timer.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/timer/tsc_timer.c b/drivers/timer/tsc_timer.c
> > index 9630036bc7f..85bdd95a819 100644
> > --- a/drivers/timer/tsc_timer.c
> > +++ b/drivers/timer/tsc_timer.c
> > @@ -464,6 +464,8 @@ unsigned long notrace timer_early_get_rate(void)
> >
> >  u64 notrace timer_early_get_count(void)
> >  {
> > +       tsc_timer_ensure_setup(true);
>
> Could you please specify why this is needed? I remember we had done
> quite some fixes to the tsc_timer to support the early timer.

It doesn't seem to be needed actually. Will drop.

Regards,
Simon


More information about the U-Boot mailing list