[U-Boot] [PATCH 1/7] spl: ymodem: Fix FIT loading termination handling

Tom Rini trini at konsulko.com
Sat Oct 12 20:23:43 UTC 2019


On Thu, Aug 15, 2019 at 03:55:26PM -0500, Andreas Dannenberg wrote:

> During FIT reading through ymodem_read_fit() the function
> xyzModem_stream_read() is being used which returns zero once the end
> of a stream has been reached. This could lead to an premature exit from
> ymodem_read_fit() with certain-sized FIT images reporting that zero
> bytes overall were read. Such a premature exit would then result in an
> -EIO failure being triggered within the spl_load_simple_fit() caller
> function and ultimately lead to a boot failure.
> 
> Fix this logic by simply aborting the stream read loops and continuing
> with the regular code flow which ultimately would lead to returning
> the number of bytes to be read ('size') as expected by the callers of
> ymodem_read_fit().
> 
> Fixes: fa715193c083 ("spl: Add an option to load a FIT containing U-Boot from UART")
> Signed-off-by: Andreas Dannenberg <dannenberg at ti.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191012/afa8ff42/attachment.sig>


More information about the U-Boot mailing list