[U-Boot] [PATCH 005/126] dm: core: Don't include ofnode functions with of-platdata

Simon Glass sjg at chromium.org
Sun Oct 13 18:24:20 UTC 2019


Hi Bin,

On Sun, 6 Oct 2019 at 19:40, Bin Meng <bmeng.cn at gmail.com> wrote:
>
> Hi Simon,
>
> On Sun, Oct 6, 2019 at 5:15 PM Bin Meng <bmeng.cn at gmail.com> wrote:
> >
> > On Thu, Oct 3, 2019 at 8:48 PM Bin Meng <bmeng.cn at gmail.com> wrote:
> > >
> > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass <sjg at chromium.org> wrote:
> > > >
> > > > These functions cannot work with of-platdata since libfdt is not
> > > > available. At present when dev_read_...() functions are used it produces
> > > > error messages about ofnode which is confusing.
> > > >
> > > > Adjust the Makefile and header to produce an error message for the actual
> > > > dev_read...() function which is called. This makes it easier to see what
> > > > code needs to be converted for use with of-platdata.
>
> As this commit message says, with this patch now it causes a large
> number of ARM boards build break. See:
> https://gitlab.denx.de/u-boot/custodians/u-boot-x86/-/jobs/16696
> https://gitlab.denx.de/u-boot/custodians/u-boot-x86/-/jobs/16697
>
> So this is intentional, but I think we should provide the build fix at
> the same time to make gitlab-CI happy.

Yes that makes sense. In fact I think I'll pull this out into a
separate series since it is better done with multiple patches.

Regards,
Simon


More information about the U-Boot mailing list