[U-Boot] [PATCH 26/34] binman: Correct symbol calculation with non-zero image base

Stephen Warren swarren at wwwdotorg.org
Mon Oct 14 15:49:47 UTC 2019


On 9/26/19 6:38 PM, sjg at google.com wrote:
> At present binman adds the image base address to the symbol value before
> it writes it to the binary. This is not correct since the symbol value
> itself (e.g. image position) has no relationship to the image base.
> 
> Fix this and update the tests to cover this case.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
> 
>   tools/binman/elf.py                      | 4 +---
>   tools/binman/test/u_boot_binman_syms.lds | 2 +-
>   2 files changed, 2 insertions(+), 4 deletions(-)
> 
> Applied to u-boot-dm, thanks!

This seems to have only just been pushed. This patch breaks boot on 
Jetson TK1; u-boot-dm.git master hangs in SPL or before the main U-Boot 
prints anything, whereas after reverting this patch solves the issue.

With this patch applied, all I get is:

U-Boot SPL 2019.10-00490-g4f035abcde98 (Oct 14 2019 - 09:48:30 -0600)
Trying to boot from RAM


More information about the U-Boot mailing list