[U-Boot] [PATCH v2] nvme: use page-aligned buffer for identify command

Bin Meng bmeng.cn at gmail.com
Wed Oct 16 10:14:47 UTC 2019


On Wed, Oct 16, 2019 at 2:42 PM Patrick Wildt <patrick at blueri.se> wrote:
>
> Change the stack-allocated buffer for the identification command
> to explicitly allocate page-aligned buffers.  Even though the spec
> seems to allow having admin queue commands on non page-aligned
> buffers, it seems to not be possible on my i.MX8MQ board with a
> a Silicon Power P34A80.  Since all of the NVMe drivers I have seen
> always do admin commands on a page-aligned buffer, which does work
> on my system, it makes sense for us to do that as well.
>
> Signed-off-by: Patrick Wildt <patrick at blueri.se>
> ---
> Changes for v2:
>    - use dev->page_size instead of hardcoded value
>
>  drivers/nvme/nvme.c | 24 ++++++++++++++++++------
>  1 file changed, 18 insertions(+), 6 deletions(-)
>

Reviewed-by: Bin Meng <bmeng.cn at gmail.com>


More information about the U-Boot mailing list