[U-Boot] [PATCH 2/3] ARM: imx: Fix bmode detection from grp10

Fabio Estevam festevam at gmail.com
Wed Oct 16 13:31:37 UTC 2019


Hi Claudius,

On Wed, Oct 16, 2019 at 10:28 AM Claudius Heine <ch at denx.de> wrote:
>
> imx6_is_bmode_from_gpr10 always returns false, because
> IMX6_SRC_GPR10_BMODE is 1<<28 and gets casted to u8 on return.
>
> Instead cast them to a boolean value before return of the function.
>
> Signed-off-by: Claudius Heine <ch at denx.de>
> ---
>  arch/arm/include/asm/mach-imx/sys_proto.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/include/asm/mach-imx/sys_proto.h b/arch/arm/include/asm/mach-imx/sys_proto.h
> index 96530e563e..b6105d0798 100644
> --- a/arch/arm/include/asm/mach-imx/sys_proto.h
> +++ b/arch/arm/include/asm/mach-imx/sys_proto.h
> @@ -91,7 +91,7 @@ enum imx6_bmode {
>
>  static inline u8 imx6_is_bmode_from_gpr10(void)

Would it make more sense to convert imx6_is_bmode_from_gpr10() to
return bool instead of u8?


More information about the U-Boot mailing list