[U-Boot] [PATCH 1/2] watchdog: imx: Add DT ext-reset handling

Robert Hancock hancock at sedsystems.ca
Wed Oct 16 16:11:34 UTC 2019


On 2019-08-07 2:28 a.m., Marek Vasut wrote:
> On 8/6/19 8:49 PM, Robert Hancock wrote:
>> On 2019-08-06 11:11 a.m., Marek Vasut wrote:
>>> On 8/6/19 7:05 PM, Robert Hancock wrote:
>>>> The Linux imx2_wdt driver uses a fsl,ext-reset-output boolean in the
>>>> device tree to specify whether the board design should use the external
>>>> reset instead of the internal reset. Use this boolean to determine which
>>>> mode to use rather than using external reset unconditionally.
>>>>
>>>> For the legacy non-DM mode, the external reset is always used in order
>>>> to maintain the previous behavior.
>>>>
>>>> Signed-off-by: Robert Hancock <hancock at sedsystems.ca>
>>>
>>> [...]
>>>
>>>> @@ -124,6 +129,8 @@ static int imx_wdt_probe(struct udevice *dev)
>>>>  	if (!priv->base)
>>>>  		return -ENOENT;
>>>>  
>>>> +	priv->ext_reset = dev_read_bool(dev, "fsl,ext-reset-output");
>>>> +
>>>
>>> Do we need a vendor-specific, undocumented, DT property ?
>>
>> It is documented in Linux in
>> Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.txt:
>>
>> - fsl,ext-reset-output: If present the watchdog device is configured to
>>   assert its external reset (WDOG_B) instead of issuing a software reset.
>>
>> I'm not aware of anything non-vendor-specific defined for this.
> 
> Aha, then please ignore my comment, thanks for clarifying.

Any updates on this patch set? It is still outstanding in patchwork:

https://patchwork.ozlabs.org/project/uboot/list/?series=123623

-- 
Robert Hancock
Senior Software Developer
SED Systems, a division of Calian Ltd.
Email: hancock at sedsystems.ca


More information about the U-Boot mailing list