[U-Boot] [PATCH v3 104/108] x86: apollolake: Add P2SB driver

[Andy Shevchenko]

On Mon, Oct 21, 2019 at 7:14 AM Simon Glass <sjg at chromium.org> wrote:
>
> Adds a driver for the apollolake Primary-to-sideband bus. This supports
> various child devices. It supposed both device tree and of-platdata.

> +static int apl_p2sb_probe(struct udevice *dev)
> +{
> +       if (spl_phase() == PHASE_TPL)
> +               return apl_p2sb_early_init(dev);

> +       else if (spl_phase() == PHASE_SPL)

Redundant 'else' (recommended to check for a such in the entire series)

> +               return apl_p2sb_spl_init(dev);
> +
> +       return 0;
> +}

-- 
With Best Regards,
Andy Shevchenko