[U-Boot] [PATCH V1 6/6] imx: imx8mm-evk: enable ethernet

Peng Fan peng.fan at nxp.com
Wed Oct 23 13:35:20 UTC 2019


> Subject: Re: [PATCH V1 6/6] imx: imx8mm-evk: enable ethernet
> 
> Hi Peng,
> 
> On Tue, Oct 22, 2019 at 12:30 AM Peng Fan <peng.fan at nxp.com> wrote:
> >
> > add phy-reset-gpios to reset phy
> > Add board_phy_config to configure phy
> > Enable DM_ETH
> >
> > Signed-off-by: Peng Fan <peng.fan at nxp.com>
> > ---
> >  arch/arm/dts/imx8mm-evk-u-boot.dtsi     |  4 ++++
> >  board/freescale/imx8mm_evk/imx8mm_evk.c | 37
> +++++++++++++++++++++++++++++++++
> >  configs/imx8mm_evk_defconfig            |  7 +++++++
> >  include/configs/imx8mm_evk.h            |  8 +++++++
> >  4 files changed, 56 insertions(+)
> >
> > diff --git a/arch/arm/dts/imx8mm-evk-u-boot.dtsi
> b/arch/arm/dts/imx8mm-evk-u-boot.dtsi
> > index f62a7cf97d..3502602fbb 100644
> > --- a/arch/arm/dts/imx8mm-evk-u-boot.dtsi
> > +++ b/arch/arm/dts/imx8mm-evk-u-boot.dtsi
> > @@ -113,3 +113,7 @@
> >  &pinctrl_pmic {
> >         u-boot,dm-spl;
> >  };
> > +
> > +&fec1 {
> > +       phy-reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
> 
> This does not seem to be U-Boot specific information.
> 
> I would suggest adding this in the main dts instead.

I have sent patches to Linux community. When that got merged, we could sync
the dts and drop it from u-boot.dtsi. But for now, I prefer to add it in u-boot.dtsi,
because Linux dts not have that for now.

Thanks,
Peng.



More information about the U-Boot mailing list