[U-Boot] [PATCH] firmware: zynqmp: Clean up zynqmp_power_probe

Michal Simek monstr at monstr.eu
Thu Oct 24 11:16:27 UTC 2019


čt 10. 10. 2019 v 11:33 odesílatel Michal Simek
<michal.simek at xilinx.com> napsal:
>
> Fix error debug messages to be more accurate and aligned with debug message
> style in the whole file.
> And do not initialize ret variable because it is initialized later on and
> it is just additional step.
>
> Fixes: 1327d1678bd2 ("firmware: zynqmp: Add zynqmp-power support")
> Reported-by: Luca Ceresoli <luca at lucaceresoli.net>
> Signed-off-by: Michal Simek <michal.simek at xilinx.com>
> ---
>
>  drivers/firmware/firmware-zynqmp.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/firmware/firmware-zynqmp.c b/drivers/firmware/firmware-zynqmp.c
> index 4911734f6c63..dea58b558102 100644
> --- a/drivers/firmware/firmware-zynqmp.c
> +++ b/drivers/firmware/firmware-zynqmp.c
> @@ -110,19 +110,19 @@ void zynqmp_pmufw_load_config_object(const void *cfg_obj, size_t size)
>
>  static int zynqmp_power_probe(struct udevice *dev)
>  {
> -       int ret = 0;
> +       int ret;
>
>         debug("%s, (dev=%p)\n", __func__, dev);
>
>         ret = mbox_get_by_name(dev, "tx", &zynqmp_power.tx_chan);
>         if (ret) {
> -               debug("%s, cannot tx mailbox\n", __func__);
> +               debug("%s: Cannot find tx mailbox\n", __func__);
>                 return ret;
>         }
>
>         ret = mbox_get_by_name(dev, "rx", &zynqmp_power.rx_chan);
>         if (ret) {
> -               debug("%s, cannot rx mailbox\n", __func__);
> +               debug("%s: Cannot find rx mailbox\n", __func__);
>                 return ret;
>         }
>
> --
> 2.17.1
>

Applied.
M

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs


More information about the U-Boot mailing list