[U-Boot] Fwd: [PULL] u-boot-usb/master

[Igor Opaniuk]

+ Heinrich,

Hi Tom, Marek, Heinrich,

On Thu, Oct 24, 2019 at 2:54 PM Tom Rini <trini at konsulko.com> wrote:
>
> It will fail with the 7.3 one buildman fetches
>
> On Thu, Oct 24, 2019, 7:34 AM Igor Opaniuk <igor.opaniuk at gmail.com> wrote:
>>
>> Hi Tom,
>>
>> On Thu, Oct 24, 2019 at 2:24 PM Tom Rini <trini at konsulko.com> wrote:
>> >
>> > On Thu, Oct 24, 2019 at 12:22:25PM +0300, Igor Opaniuk wrote:
>> > > Hi Tom,
>> > >
>> > > On Wed, Oct 23, 2019 at 10:36 PM Marek Vasut <marex at denx.de> wrote:
>> > > >
>> > > > On 10/23/19 9:26 PM, Tom Rini wrote:
>> > > > > On Sun, Oct 20, 2019 at 05:08:37PM +0200, Marek Vasut wrote:
>> > > > >
>> > > > >> The following changes since commit 6891152a4596d38ac25d2fe1238e3b6a938554b8:
>> > > > >>
>> > > > >>   Merge branch 'master' of git://git.denx.de/u-boot-socfpga (2019-10-14
>> > > > >> 21:00:10 -0400)
>> > > > >>
>> > > > >> are available in the Git repository at:
>> > > > >>
>> > > > >>   git://git.denx.de/u-boot-usb.git master
>> > > > >>
>> > > > >> for you to fetch changes up to 79b03816cb7d17ce717cbeb2d1c69836a0adef1e:
>> > > > >>
>> > > > >>   dm: test: usb: rework keyboard test (2019-10-15 13:12:09 +0200)
>> > > > >>
>> > > > >
>> > > > > Two problems.  First (and I was going to fix this myself, it's not too
>> > > > > hard) is that the DWC3 series is once again out of date with new
>> > > > > platforms added since posting, this time khadas-vim3 and sei610.
>> > > >
>> > > > Lovely, CCing Jean again ...
>> > > >
>> > > > > But the second and bigger problem is that (I assume) the mx6 patch makes
>> > > > > tbs2910 now exceed the binary size limit and fail to link.
>> > >
>> > > Could you please provide steps to reproduce (or just point to CI build log).
>> > > I've tried building both u-boot-usb tree and u-boot with all changes
>> > > from this PR
>> > > applied on top. In all cases everything is OK:
>> > >
>> > > $ make tbs2910_defconfig
>> > > $ make
>> > > #
>> > > # configuration written to .config
>> > > #
>> > > ....
>> > >   OBJCOPY u-boot-nodtb.bin
>> > >   COPY    u-boot.bin
>> > >   MKIMAGE u-boot.imx
>> > >   OBJCOPY u-boot.srec
>> > >   SYM     u-boot.sym
>> > > ===================== WARNING ======================
>> > > This board does not use CONFIG_DM_VIDEO Please update
>> > > the board to use CONFIG_DM_VIDEO before the v2019.07 release.
>> > > Failure to update by the deadline may result in board removal.
>> > > See doc/driver-model/MIGRATION.txt for more info.
>> > > ====================================================
>> > > ===================== WARNING ======================
>> > > CONFIG_OF_EMBED is enabled. This option should only
>> > > be used for debugging purposes. Please use
>> > > CONFIG_OF_SEPARATE for boards in mainline.
>> > > See doc/README.fdt-control for more info.
>> > > ====================================================
>> > >   CFGCHK  u-boot.cfg
>> >
>> > What toolchain are you using?  Thanks!
>> It's gcc-arm-8.2-2019.01
>>
>> >
>> > --
>> > Tom
>>
>> After discussion with Marek in IRC, found out that
>> this issue is definitely toolchain dependent .
>>
>> I've managed to reproduce this with buildman (and gcc-7.3.0, which is
>> fetched by default)
>>
>> $ ./tools/buildman/buildman --board=tbs2910
>> boards.cfg is up to date. Nothing to do.
>> Building current source for 1 boards (1 thread, 8 jobs per thread)
>>        arm:  +   tbs2910
>> +u-boot.imx exceeds file size limit:
>> +/bin/sh: 1: printf: bytes: expected numeric value
>> +  limit:  00x5fc00 bytes
>> +  actual: 0x60c00 bytes
>> +  excess: 0x1000 bytes
>> +make[1]: *** [u-boot.imx] Error 1
>> +make[1]: *** Deleting file 'u-boot.imx'
>> +make: *** [sub-make] Error 2
>>     0    0    1 /1      tbs2910
>>
>> Thanks
>>
>> --
>> Best regards - Freundliche Grüsse - Meilleures salutations
>>
>> Igor Opaniuk
>>
>> mailto: igor.opaniuk at gmail.com
>> skype: igor.opanyuk
>> +380 (93) 836 40 67
>> http://ua.linkedin.com/in/iopaniuk

It's not really mx6-ehci commit which blows up the size
I've bisected to (within u-boot-usb/master):

5662d00290164a7408cfcf09923d3fcd36306b62 is the first bad commit
commit 5662d00290164a7408cfcf09923d3fcd36306b62
Author: Heinrich Schuchardt <xypron.glpk at gmx.de>
Date:   Thu Oct 10 23:36:56 2019 +0200

    usb: kbd: implement special keys

    Provide support for F1-F12, Insert, Delete, Home, End, Page Up, Page Down.

    Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
    Reviewed-by: Simon Glass <sjg at chromium.org>


BTW,  6f37f1ecf2 ("usb: ehci-mx6: Fix bus enumeration for iMX7 SoCs")
doesn't have
any impact at u-boot.imx binary size at all:

5662d00290 usb: kbd: implement special keys - size 60c00
5f1a4d817d usb: kbd: simplify coding for arrow keys  - size 5fc00
6f37f1ecf2 usb: ehci-mx6: Fix bus enumeration for iMX7 SoCs - size 5fc00
73e5ee094c ARM: DTS: keystone: complete the description of the USB PHY
devices - size 5fc00


-- 
Best regards - Freundliche Grüsse - Meilleures salutations

Igor Opaniuk

mailto: igor.opaniuk at gmail.com
skype: igor.opanyuk
+380 (93) 836 40 67
http://ua.linkedin.com/in/iopaniuk