[U-Boot] [PATCH 0/9] phy: atheros: cleanup and device tree bindings

[Michael Walle]

Hi Adam,

Am 2019-10-26 05:28, schrieb Adam Ford:
> On Fri, Oct 25, 2019 at 10:20 PM Adam Ford <aford173 at gmail.com> wrote:
>> 
>> On Fri, Oct 25, 2019 at 7:27 PM Michael Walle <michael at walle.cc> 
>> wrote:
>> >
>> > This series cleans up the Atheros PHY AR803x PHY driver and adds a
>> > device tree binding for the most commonly used PHY settings like clock
>> > output.
>> >
>> > If you're a board maintainer you're getting this mail because you probably
>> > use an AR803x PHY on your board. Please have a look at your board specific
>> > code and see if you can use the device tree bindings instead. Let me know,
>> > if something is missing.
>> 
>> Thank you for this!
>> 
>> I was able to remove board_phy_config and the supporting
>> ar8031_phy_fixup functions to a total of nearly 30 lines of code.
> 
> Please disregard my comment.  From a cold boot, I cannot remove these 
> lines.

Thank you for testing though. I guess your network drivers needs 
something like that:
   https://patchwork.ozlabs.org/patch/1184523/

So here is a cheap shot (very hacky, doesn't work with 
CONFIG_FEC_MXC_PHYADDR, completely untested, not even compiled ;). Could 
you try that? I need to add some debug messages to the Atheros PHY 
driver, so one could see if the device tree binding is working 
correctly.

--- a/drivers/net/fec_mxc.c
+++ b/drivers/net/fec_mxc.c
@@ -1264,7 +1264,7 @@ static const struct eth_ops fecmxc_ops = {
         .read_rom_hwaddr        = fecmxc_read_rom_hwaddr,
  };

-static int device_get_phy_addr(struct udevice *dev)
+static int device_get_phy_addr(struct udevice *dev, struct ofnode 
*phy_node)
  {
         struct ofnode_phandle_args phandle_args;
         int reg;
@@ -1276,6 +1276,7 @@ static int device_get_phy_addr(struct udevice 
*dev)
         }

         reg = ofnode_read_u32_default(phandle_args.node, "reg", 0);
+       phy_node = &phandle_args.node;

         return reg;
  }
@@ -1284,8 +1285,9 @@ static int fec_phy_init(struct fec_priv *priv, 
struct udevice *dev)
  {
         struct phy_device *phydev;
         int addr;
+       ofnode *phy_node;

-       addr = device_get_phy_addr(dev);
+       addr = device_get_phy_addr(dev, &phy_node);
  #ifdef CONFIG_FEC_MXC_PHYADDR
         addr = CONFIG_FEC_MXC_PHYADDR;
  #endif
@@ -1294,6 +1296,7 @@ static int fec_phy_init(struct fec_priv *priv, 
struct udevice *dev)
         if (!phydev)
                 return -ENODEV;

+       phydev->node = phy_node;
         priv->phydev = phydev;
         phy_config(phydev);


-michael