[U-Boot] [PATCH 16/30] efi: Tidy up header includes

Simon Glass sjg at chromium.org
Sun Oct 27 18:59:44 UTC 2019

Hi Heinrich,

On Sun, 27 Oct 2019 at 11:42, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
> On 10/27/19 4:53 PM, Simon Glass wrote:> Two files relay on efi_driver.h
> to include common.h and dm.h which is
> %s/relay/rely/
> > incorrect. The former should always be included in a non-host C file and
> > the latter should be included if driver model is used.
> https://www.denx.de/wiki/U-Boot/CodingStyle does no mention these
> requirements. Does the wiki need an update?

OK I added a bit of an update. Feel free to improve it.

> Non-host C files not including common.h at all or not as the first
> include call for trouble, cf.
> https://lists.denx.de/pipermail/u-boot/2019-October/388406.html
> https://lists.denx.de/pipermail/u-boot/2019-October/388408.html
> As your patch makes it obvious that common.h is included first:
> Reviewed-by: Heinrich Schuchardt <xypron.glpk at gmx.de>

Thanks...at some point we might consider running a tool over the code
base to sort the includes.


More information about the U-Boot mailing list