[U-Boot] [PATCH 06/30] wdt: Drop dm.h header file

Stefan Roese sr at denx.de
Mon Oct 28 05:44:42 UTC 2019


On 27.10.19 16:53, Simon Glass wrote:
> This header file should not be included in other header files. Remove it
> and use a forward declaration instead.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
> 
>   include/wdt.h | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/include/wdt.h b/include/wdt.h
> index 5698605c02..62f4b34c30 100644
> --- a/include/wdt.h
> +++ b/include/wdt.h
> @@ -6,8 +6,7 @@
>   #ifndef _WDT_H_
>   #define _WDT_H_
>   
> -#include <dm.h>
> -#include <dm/read.h>
> +struct udevice;

I'm not a big fan of forward declarations. But if this helps with
overall cleanup and compile speed:

Reviewed-by: Stefan Roese <sr at denx.de>

Thanks,
Stefan


More information about the U-Boot mailing list