[U-Boot] [PATCH v2 1/5] tools: buildman: Honor output directory when generating boards.cfg
bmeng.cn at gmail.com
Tue Oct 29 07:11:15 UTC 2019
On Tue, Oct 29, 2019 at 11:32 AM Simon Glass <sjg at chromium.org> wrote:
> Hi Bin,
> On Mon, 28 Oct 2019 at 08:25, Bin Meng <bmeng.cn at gmail.com> wrote:
> > buildman always generates boards.cfg in the U-Boot source tree.
> > When '-o' is given, we should generate boards.cfg to the given
> > output directory.
> > Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
> > ---
> > Changes in v2: None
> > tools/buildman/control.py | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> Reviewed-by: Simon Glass <sjg at chromium.org>
> Does this preserve existing behaviour when -o is not given? I suppose
When -o is not given, the options.output_dir is the destination
directory and it's "../" by default.
But I suspect we should change the default output_dir to somewhere
else, in a separate patch, because arbitrarily put something in the
parent directory is not a good practice.
> it doesn't matter so long as buildman uses the right file?
Yes, it doesn't matter.
More information about the U-Boot