[U-Boot] [PATCH v2 2/5] tools: buildman: Remove useless mkdir() in Make() in test.py

Bin Meng bmeng.cn at gmail.com
Tue Oct 29 13:56:16 UTC 2019


Hi Simon,

On Tue, Oct 29, 2019 at 11:37 AM Simon Glass <sjg at chromium.org> wrote:
>
> Hi Bin,
>
> On Mon, 28 Oct 2019 at 08:25, Bin Meng <bmeng.cn at gmail.com> wrote:
> >
> > In the 'Make' function, the codes tries to create a directory
> > if current stage is 'build'. But the directory isn't used at
> > all anywhere.
> >
> > Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
> >
> > ---
> >
> > Changes in v2:
> > - remove the unneeded debug codes
> >
> >  tools/buildman/test.py | 8 --------
> >  1 file changed, 8 deletions(-)
>
> Can you check this works OK when there is no output dir at all? E.g.
>
> -o /path/to/a/deep/non-existent/dir

If I understand the codes correctly the "O=<path>" in args[] does not
come from "-o /path/to/a/deep/non-existent/dir" but from the
builderthread with some hardcoded values. The removed codes here seem
to do something not very useful.

>
> Reviewed-by: Simon Glass <sjg at chromium.org>

Regards,
Bin


More information about the U-Boot mailing list