[U-Boot] [PATCH v1 2/3] drivers: reset: Add a managed API to get reset controllers from the DT

Simon Glass sjg at chromium.org
Wed Oct 30 01:48:46 UTC 2019


On Mon, 30 Sep 2019 at 10:15, Jean-Jacques Hiblot <jjhiblot at ti.com> wrote:
>
> Add managed functions to get a reset_ctl from the device-tree, based on a
> name or an index.
> Also add a managed functions to get a reset_ctl_bulk (array of reset_ctl)
> from the device-tree.
>
> When the device is unbound, the reset controllers are automatically
> released and the data structure is freed.
>
> Signed-off-by: Jean-Jacques Hiblot <jjhiblot at ti.com>
> ---
>
>  drivers/reset/reset-uclass.c | 116 +++++++++++++++++++++++++++++-
>  include/reset.h              | 135 ++++++++++++++++++++++++++++++++++-
>  2 files changed, 247 insertions(+), 4 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>

I really don't like these ERR_PTR returns. I suppose they make the
code easier to port, and we can be sure that pointers will not be in
the last 4KB of address space?

Regards,
Simon


More information about the U-Boot mailing list