[U-Boot] [PATCH 6/8] spl: cache: Allow cache drivers in SPL

[Rick Chen]

Hi Bin

>
> Hi Rick,
>
> On Fri, Oct 25, 2019 at 2:18 PM Andes <uboot at andestech.com> wrote:
> >
> > From: Rick Chen <rick at andestech.com>
> >
> > When ax25-ae350 try to enable v5l2 cache
> > driver in SPL configuration, it need this
> > option for cache support in SPL.
> >
> > Signed-off-by: Rick Chen <rick at andestech.com>
> > Cc: KC Lin <kclin at andestech.com>
> > Cc: Alan Kao <alankao at andestech.com>
> > ---
> >  common/spl/Kconfig | 7 +++++++
> >  drivers/Makefile   | 1 +
> >  2 files changed, 8 insertions(+)
> >
> > diff --git a/common/spl/Kconfig b/common/spl/Kconfig
> > index 86d7edf..4c4023a 100644
> > --- a/common/spl/Kconfig
> > +++ b/common/spl/Kconfig
> > @@ -456,6 +456,13 @@ config SPL_CRYPTO_SUPPORT
> >           this option to build the drivers in drivers/crypto as part of an
> >           SPL build.
> >
> > +config SPL_CACHE_SUPPORT
>
> nits: please insert this option per alphabetical order, so it should
> come before SPL_CPU

OK

>
> > +       bool "Support CACHE drivers"
> > +       help
> > +         Enable CACHE drivers in SPL. These drivers can store data so that
> > +         future requests for that data can be served faster. Enable this option
>
> The description here "store data so that ..." does not apply to cache drivers

Do you have any suggestions about how to describe it more precisely ?

Thanks
Rick

>
> > +         to build the drivers in drivers/cache as part of an SPL build.
> > +
> >  config SPL_HASH_SUPPORT
> >         bool "Support hashing drivers"
> >         select SHA1
> > diff --git a/drivers/Makefile b/drivers/Makefile
> > index a4bb5e4..5d300df 100644
> > --- a/drivers/Makefile
> > +++ b/drivers/Makefile
> > @@ -33,6 +33,7 @@ ifdef CONFIG_SPL_BUILD
> >  obj-$(CONFIG_SPL_BOOTCOUNT_LIMIT) += bootcount/
> >  obj-$(CONFIG_SPL_CPU_SUPPORT) += cpu/
> >  obj-$(CONFIG_SPL_CRYPTO_SUPPORT) += crypto/
> > +obj-$(CONFIG_SPL_CACHE_SUPPORT) += cache/
>
> ditto

OK

>
> >  obj-$(CONFIG_SPL_MPC8XXX_INIT_DDR_SUPPORT) += ddr/fsl/
> >  obj-$(CONFIG_ARMADA_38X) += ddr/marvell/a38x/
> >  obj-$(CONFIG_ARMADA_XP) += ddr/marvell/axp/
> > --
>
> Regards,
> Bin