[U-Boot] [PATCH 1/1] net: nfs: remove superfluous conversions

Joe Hershberger joe.hershberger at ni.com
Tue Sep 3 21:25:10 UTC 2019

On Mon, Sep 2, 2019 at 4:55 PM Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
> rpc_pkt.u.call.data is an array of uint32_t. There is no need to convert
> it to uint32_t *.
> memcpy() expects void * as it 1st and 2nd argument. There is no point in
> converting pointers to char * before passing them to memcpy().
> In ntohl(data[1]) != 0 calling ntohl() is superfluous. If the value is
> zero, does not depend on the byte order.
> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>

Acked-by: Joe Hershberger <joe.hershberger at ni.com>

More information about the U-Boot mailing list