[U-Boot] [PATCH 1/1] net: nfs: remove superfluous packed attribute

Joe Hershberger joe.hershberger at ni.com
Tue Sep 3 23:51:44 UTC 2019


On Mon, Sep 2, 2019 at 5:05 PM Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>
> With GCC 9.2.1 net/nfs.c leads to multiple errors of type
> address-of-packed-member.
>
> net/nfs.c: In function ‘rpc_req’:
> net/nfs.c:199:18: error: taking address of packed member of
> ‘struct rpc_t’ may result in an unaligned pointer value
> [-Werror=address-of-packed-member]
>   199 |  p = (uint32_t *)&(rpc_pkt.u.call.data);
>       |                  ^~~~~~~~~~~~~~~~~~~~~~
> net/nfs.c: In function ‘nfs_readlink_reply’:
> net/nfs.c:631:46: error: taking address of packed member of
> ‘struct rpc_t’ may result in an unaligned pointer value
> [-Werror=address-of-packed-member]
>   631 |    nfs3_get_attributes_offset(rpc_pkt.u.reply.data);
>       |                               ~~~~~~~~~~~~~~~^~~~~
>   LD      drivers/block/built-in.o
> net/nfs.c: In function ‘nfs_read_reply’:
> net/nfs.c:692:46: error: taking address of packed member of
> ‘struct rpc_t’ may result in an unaligned pointer value
> [-Werror=address-of-packed-member]
>   692 |    nfs3_get_attributes_offset(rpc_pkt.u.reply.data);
>       |                               ~~~~~~~~~~~~~~~^~~~~
>
> struct rpc_t is only used as local variable. It is naturally packed. So
> there is no need for the attribute packed.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>

Acked-by: Joe Hershberger <joe.hershberger at ni.com>


More information about the U-Boot mailing list