[U-Boot] [PATCH v3 6/7] mmc: Replace printf with debug call for timeouts in the i.MX28 mxs driver

Lukasz Majewski lukma at denx.de
Thu Sep 5 07:55:00 UTC 2019

This change replaces printf() with debug() for the notification about
commands timeouts.

This is done on purpose (also other drivers use such approach - dw_mmc.c,
mvebu_mmc.c), as the mmc core code (mmc.c) uses timeouts to assess if one
is using sd card or eMMC device.
In such situation timeout is a some kind of a "normal" behavior and there
shall not be any output to the console.

There is no impact on boot time for boards using this driver (even in SPL)
when two extra timeouts are returned (no SD card present, only eMMC

Boot time tested with grabserial:
sudo grabserial -b 115200 -d /dev/ttyUSB1 -e 30 -t -m "^U-Boot SPL*"

Signed-off-by: Lukasz Majewski <lukma at denx.de>

Changes in v3: None
Changes in v2:
- New patch

 drivers/mmc/mxsmmc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/mxsmmc.c b/drivers/mmc/mxsmmc.c
index 7ea47f9801..9414eff42b 100644
--- a/drivers/mmc/mxsmmc.c
+++ b/drivers/mmc/mxsmmc.c
@@ -432,8 +432,8 @@ mxsmmc_send_cmd(struct udevice *dev, struct mmc_cmd *cmd, struct mmc_data *data)
 	/* Check command timeout */
-		printf("MMC%d: Command %d timeout (status 0x%08x)\n",
-		       devnum, cmd->cmdidx, reg);
+		debug("MMC%d: Command %d timeout (status 0x%08x)\n",
+		      devnum, cmd->cmdidx, reg);
 		return -ETIMEDOUT;

More information about the U-Boot mailing list