[U-Boot] [PATCH v2] patman: Use the Change-Id, version, and prefix in the Message-Id

Johannes Berg johannes at sipsolutions.net
Thu Sep 5 19:48:41 UTC 2019


On Tue, 2019-09-03 at 13:15 -0700, Douglas Anderson wrote:
> 
> Let's give that a try.
> 
> In theory (if there is enough adoption) this could help a tool more
> reliably find various versions of a commit.

It's not quite as good as this (yet), but a very simple version of it
for git-send-email could be this:

--- save as .git/hooks/sendemail-validate ---
#!/bin/sh

set -e

changeid=$(sed 's/^Change-Id: \(I.*\)$/\1/;t;d' $1)
date=$(date +%s)
sed 's/^Change-Id: I.*$//;T;d' -i $1
sed "s/^From: /Message-Id: <$date-$changeid at changeid>\nFrom: /" -i $1
#--- end script ---


It won't do the RFC/which patch of a series etc. but I consider that
less interesting.

Actually, the important part for me is to be to be able to have change-
ids locally (e.g. for working with gerrit), and not have that leak out
to the community (that doesn't like them).

As a maintainer in the community, I'll also need to change the
.git/hooks/commit-msg script that comes with gerrit to not add a Change-
Id if the commit comes with a Link: tag already, but that should be
easy.

johannes



More information about the U-Boot mailing list