[U-Boot] [PATCH v2 1/4] dm: spi: Return 0 if driver does not implement ops->cs_info
bmeng.cn at gmail.com
Mon Sep 9 13:00:00 UTC 2019
If an SPI controller driver does not implement ops->cs_info, that
probably means any chip select number could be valid, hence let's
return 0 for spi_cs_info().
Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
Reviewed-by: Jagan Teki <jagan at amarulasolutions.com>
Changes in v2:
- update spi-howto.rst to reflect the code changes
doc/driver-model/spi-howto.rst | 4 ++--
drivers/spi/spi-uclass.c | 7 +++----
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/doc/driver-model/spi-howto.rst b/doc/driver-model/spi-howto.rst
index a538fdc..7e64fae 100644
@@ -634,8 +634,8 @@ method for cs_info() to deal with this. If you don't provide it, then the
device tree will be used to determine what chip selects are valid.
Return -ENODEV if the supplied chip select is invalid, or 0 if it is valid.
-If you don't provide the cs_info() method, -ENODEV is assumed for all
-chip selects that do not appear in the device tree.
+If you don't provide the cs_info() method, 0 is assumed for all chip selects
+that do not appear in the device tree.
diff --git a/drivers/spi/spi-uclass.c b/drivers/spi/spi-uclass.c
index 88cb2a1..24de0b5 100644
@@ -237,11 +237,10 @@ int spi_cs_info(struct udevice *bus, uint cs, struct spi_cs_info *info)
return ops->cs_info(bus, cs, info);
- * We could assume there is at least one valid chip select, but best
- * to be sure and return an error in this case. The driver didn't
- * care enough to tell us.
+ * We could assume there is at least one valid chip select.
+ * The driver didn't care enough to tell us.
- return -ENODEV;
+ return 0;
int spi_find_bus_and_cs(int busnum, int cs, struct udevice **busp,
More information about the U-Boot