[U-Boot] [PATCH v3 2/2] x86: efi_loader: Use efi_add_conventional_memory_map()

[Park, Aiden]

Hi Bin,

> -----Original Message-----
> From: Heinrich Schuchardt [mailto:xypron.glpk at gmx.de]
> Sent: Tuesday, September 3, 2019 12:21 PM
> To: Park, Aiden <aiden.park at intel.com>; Bin Meng <bmeng.cn at gmail.com>;
> Alexander Graf <agraf at csgraf.de>; u-boot at lists.denx.de
> Subject: Re: [PATCH v3 2/2] x86: efi_loader: Use
> efi_add_conventional_memory_map()
> 
> On 9/3/19 7:43 PM, Park, Aiden wrote:
> > Use efi_add_conventional_memory_map() to configure EFI conventional
> > memory properly with ram_top value. This will give 32bit mode U-Boot
> > proper conventional memory regions even if e820 has a entry which is
> > greater than 32bit address space.
> >
> > Signed-off-by: Aiden Park <aiden.park at intel.com>
> 
> Together with Bin's patch series for supporting >3GB
> (https://lists.denx.de/pipermail/u-boot/2019-August/382332.html) I see the
> following memory map on an 8GB qemu-x86_defconfig
> (CONFIG_CMD_EFIDEBUG=y):
> 
> ==> efidebug memmap
> Type             Start            End              Attributes
> ================ ================ ================ ==========
> CONVENTIONAL     0000000000000000-00000000000a0000 WB
> RESERVED         00000000000a0000-0000000000100000 WB
> CONVENTIONAL     0000000000100000-00000000becf4000 WB
> LOADER DATA      00000000becf4000-00000000becf5000 WB
> BOOT DATA        00000000becf5000-00000000becf6000 WB
> RUNTIME DATA     00000000becf6000-00000000bed07000 WB|RT
> BOOT DATA        00000000bed07000-00000000bed09000 WB
> RESERVED         00000000bed09000-00000000bed0a000 WB
> BOOT DATA        00000000bed0a000-00000000bed0c000 WB
> RUNTIME DATA     00000000bed0c000-00000000bed0d000 WB|RT
> LOADER DATA      00000000bed0d000-00000000bff4f000 WB
> RUNTIME CODE     00000000bff4f000-00000000bff50000 WB|RT
> LOADER DATA      00000000bff50000-00000000c0000000 WB
> RESERVED         00000000e0000000-00000000f0000000 WB
> BOOT DATA        0000000100000000-0000000240000000 WB
> 
> Close to 3GB in low memory and 5 GB above the 4GB boundary.
> 
> Tested-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> Reviewed-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> 
> @Bin:
> If you plan to create a pull request for RC4, you can take both patches to avoid
> unnecessary dependencies.
> 
> Otherwise I will try to get patch 1/2 into RC4.
> 
In U-Boot master branch, it looks Heinrich did pull request with patch 1/2 and
it was already merged. Can you merge patch 2/2 as well? This blocks OS booting
on real hardware. Appreciate your help.

> Best regards
> 
> Heinrich

Best Regards,
Aiden