[U-Boot] rk3288: HDMI out causing boot hang

[Michael Nazzareno Trimarchi]

Hi

On Fri, Sep 13, 2019 at 5:02 PM Michael Nazzareno Trimarchi
<michael at amarulasolutions.com> wrote:
>
> Hi
>
> On Fri, Sep 13, 2019 at 4:02 PM Michael Nazzareno Trimarchi
> <michael at amarulasolutions.com> wrote:
> >
> > Hi Anatolij
> >
> > On Fri, Sep 13, 2019 at 4:01 PM Anatolij Gustschin <agust at denx.de> wrote:
> > >
> > > Hi Jagan,
> > >
> > > On Fri, 13 Sep 2019 08:19:47 +0530
> > > Jagan Teki jagan at amarulasolutions.com wrote:
> > > ...
> > > > Any inputs?
> > >
> > > Try to input "setenv stdout serial" command on the serial console.
> > > There might be a chance that stdout/stdin has switched to the
> > > video console and the output proceeds there. If the HDMI display
> > > shows nothing, it appears like a hang.
> >
> > It's not an hang. It's the output is not shown. I'm trying to
> > understand the reason

It was a bug of the old uboot

commit 79cdcaced710d955f68066d02327b86be573339c
Author: Niklas Schulze <me at jns.io>
Date:   Sun Jul 14 10:40:13 2019 +0000

    rockchip: video: rk3288_hdmi: Add missing call to dw_hdmi_enable()

    The RK3288 HDMI driver's rk3288_hdmi_enable() currently lacks a call to
    dw_hdmi_enable(). Thus, the HDMI output never gets enabled.

    Signed-off-by: Niklas Schulze <me at jns.io>
    Cc: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>
    Reviewed-by: Kever Yang <Kever.yang at rock-chips.com>
    Reviewed-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>

diff --git a/drivers/video/rockchip/rk3288_hdmi.c
b/drivers/video/rockchip/rk3288_hdmi.c
index 315d3adf27..3d25ce924c 100644
--- a/drivers/video/rockchip/rk3288_hdmi.c
+++ b/drivers/video/rockchip/rk3288_hdmi.c
@@ -33,7 +33,7 @@ static int rk3288_hdmi_enable(struct udevice *dev,
int panel_bpp,
        /* hdmi data from vop id */
        rk_clrsetreg(&grf->soc_con6, 1 << 4, (vop_id == 1) ? (1 << 4) : 0);

-       return 0;
+       return dw_hdmi_enable(&priv->hdmi, edid);
 }

Now I need to test the mainline one

Michael

> >
>
> I have fixed, still not so good ;)
>
> Michael
>
> > Michael
> > >
> > > --
> > > Anatolij
> > >
> > > _______________________________________________
> > > Linux-rockchip mailing list
> > > Linux-rockchip at lists.infradead.org
> > > http://lists.infradead.org/mailman/listinfo/linux-rockchip
> >
> >
> >
> > --
> > | Michael Nazzareno Trimarchi                     Amarula Solutions BV |
> > | COO  -  Founder                                      Cruquiuskade 47 |
> > | +31(0)851119172                                 Amsterdam 1018 AM NL |
> > |                  [`as] http://www.amarulasolutions.com               |
>
>
>
> --
> | Michael Nazzareno Trimarchi                     Amarula Solutions BV |
> | COO  -  Founder                                      Cruquiuskade 47 |
> | +31(0)851119172                                 Amsterdam 1018 AM NL |
> |                  [`as] http://www.amarulasolutions.com               |



-- 
| Michael Nazzareno Trimarchi                     Amarula Solutions BV |
| COO  -  Founder                                      Cruquiuskade 47 |
| +31(0)851119172                                 Amsterdam 1018 AM NL |
|                  [`as] http://www.amarulasolutions.com               |