[U-Boot] [PATCH v2] cmd: pxe: Use internal FDT if retrieving from FDTDIR fails

Anton Leontiev scileont at gmail.com
Tue Sep 17 06:07:37 UTC 2019


2019-09-03 19:18, Stephen Warren <swarren at wwwdotorg.org>:
> Is it possible/sensible to distinguish between "file not found" and
> "error during retrieval"? "File not found" indicates the case you care
> about, and continuing to use a built-in DT makes sense here. "Error
> during retrieval" indicates that the file was found, and hence really
> should be use, yet couldn't be due to download failure. In this case, I
> wonder if we shouldn't outright fail this boot option, just like the
> existing code does?
>
> But either way, I suppose this patch is reasonable.

As I see, for example from do_get_ext2(), currently it is not possible
to distinguish between "file not found" and "error during retrieval".
It seems possible to update all do_get_*() functions to check file
existence before retrieving, but it will require extensive testing and
I prefer this to be changed independently to current patch.

Best regards,

-- 
Anton Leontiev


More information about the U-Boot mailing list