[U-Boot] [PATCH 04/14] dfu: allow to manage DFU on several devices

[Patrick DELAUNAY]

Hi Lukasz,

> From: Lukasz Majewski <lukma at denx.de>
> Sent: mardi 17 septembre 2019 12:26
> To: Patrick DELAUNAY <patrick.delaunay at st.com>
> Cc: u-boot at lists.denx.de; U-Boot STM32 <uboot-stm32 at st-md-
> mailman.stormreply.com>
> Subject: Re: [PATCH 04/14] dfu: allow to manage DFU on several devices
> Importance: High
> 
> Hi Patrick,
> 
> > Add support of DFU for several interface/device with one command.
> >
> > The format for "dfu_alt_info" in this case is :
> >   interface with devstring'='alternate list (';' separated)
> >   and each interface is separated by '&'
> >
> > The previous behavior is always supported.
> >
> > One example for NOR (bootloaders) + NAND (rootfs in UBI):
> >
> > U-Boot> env set dfu_alt_info \
> > "sf 0:0:10000000:0=spl part 0 1;u-boot part 0 2; \ u-boot-env part 0
> > 3&nand 0=UBI partubi 0,3"
> >
> > U-Boot> dfu 0 list
> >
> > DFU alt settings list:
> > dev: SF alt: 0 name: spl layout: RAW_ADDR
> > dev: SF alt: 1 name: ssbl layout: RAW_ADDR
> > dev: SF alt: 2 name: u-boot-env layout: RAW_ADDR
> > dev: NAND alt: 3 name: UBI layout: RAW_ADDR
> >
> > U-Boot> dfu 0
> >
> > $> dfu-util -l
> >
> > Found DFU: [0483:5720] ver=9999, devnum=96, cfg=1,\  intf=0, alt=3,
> > name="UBI", serial="002700333338511934383330"
> > Found DFU: [0483:5720] ver=9999, devnum=96, cfg=1,\  intf=0, alt=2,
> > name="u-boot-env", serial="002700333338511934383330"
> > Found DFU: [0483:5720] ver=9999, devnum=96, cfg=1,\  intf=0, alt=1,
> > name="u-boot", serial="002700333338511934383330"
> > Found DFU: [0483:5720] ver=9999, devnum=96, cfg=1,\  intf=0, alt=0,
> > name="spl", serial="002700333338511934383330"
> >
> 
> My two remarks:
> 
> 1. As you mentioned above - the current behavior must be preserved (this is my
> main concern).

I agree, it was also my concern.

I don't indicated it clearly by I test it on my board and it but it is preserved.

For example, on my stm32mp1 board :

STM32MP> env set dfu_alt_info "sdcard_fsbl1 part 0 1;sdcard_fsbl2 part 0 2;sdcard_ssbl part 0 3;sdcard_bootfs part 0 4;sdcard_vendorfs part 0 5;sdcard_rootfs part 0 6"
STM32MP> dfu 0 mmc 0

On the host side 

dfu-util -l
dfu-util 0.9

Copyright 2005-2009 Weston Schmidt, Harald Welte and OpenMoko Inc.
Copyright 2010-2016 Tormod Volden and Stefan Schmidt
This program is Free Software and has ABSOLUTELY NO WARRANTY
Please report bugs to http://sourceforge.net/p/dfu-util/tickets/

Found DFU: [0483:df11] ver=0200, devnum=17, cfg=1, intf=0, path="3-1.3.1", alt=5, name="sdcard_rootfs", serial="002700333338511934383330"
Found DFU: [0483:df11] ver=0200, devnum=17, cfg=1, intf=0, path="3-1.3.1", alt=4, name="sdcard_vendorfs", serial="002700333338511934383330"
Found DFU: [0483:df11] ver=0200, devnum=17, cfg=1, intf=0, path="3-1.3.1", alt=3, name="sdcard_bootfs", serial="002700333338511934383330"
Found DFU: [0483:df11] ver=0200, devnum=17, cfg=1, intf=0, path="3-1.3.1", alt=2, name="sdcard_ssbl", serial="002700333338511934383330"
Found DFU: [0483:df11] ver=0200, devnum=17, cfg=1, intf=0, path="3-1.3.1", alt=1, name="sdcard_fsbl2", serial="002700333338511934383330"
Found DFU: [0483:df11] ver=0200, devnum=17, cfg=1, intf=0, path="3-1.3.1", alt=0, name="sdcard_fsbl1", serial="002700333338511934383330"


> 2. You added the example of usage to the commit message. Could you also add it
> to the ./doc/README.dfu (not yet present) file ?

Yes I willl create the file in V2

> Anyway, thanks for your work :-)
> 
> > Signed-off-by: Patrick Delaunay <patrick.delaunay at st.com>
> 
> Acked-by: Lukasz Majewski <lukma at denx.de>
> 

Regards

Patrick