[U-Boot] [PATCH v2 1/2] dm: core: Add functions to read 64-bit dt properties

[Michal Simek]

On 17. 09. 19 7:47, Simon Glass wrote:
> On Mon, 2 Sep 2019 at 09:24, Bin Meng <bmeng.cn at gmail.com> wrote:
>>
>> On Mon, Sep 2, 2019 at 10:34 PM Michal Simek <michal.simek at xilinx.com> wrote:
>>>
>>> From: T Karthik Reddy <t.karthik.reddy at xilinx.com>
>>>
>>> This patch adds functions dev_read_u64_default & dev_read_u64
>>> to read unsigned 64-bit values from devicetree.
>>>
>>> Signed-off-by: T Karthik Reddy <t.karthik.reddy at xilinx.com>
>>> Signed-off-by: Michal Simek <michal.simek at xilinx.com>
>>> ---
>>>
>>> Changes in v2:
>>> - Moved newly added 64-bit funtion definations & prototypes below
>>>    32-bit functions.
>>>
>>>  drivers/core/ofnode.c |  2 +-
>>>  drivers/core/read.c   | 10 ++++++++++
>>>  include/dm/ofnode.h   |  2 +-
>>>  include/dm/read.h     | 33 +++++++++++++++++++++++++++++++++
>>>  4 files changed, 45 insertions(+), 2 deletions(-)
>>>
>>
>> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
> 
> How about adding a few tests for these new functions?
> 
> See for example here:
> 
> https://gitlab.denx.de/u-boot/custodians/u-boot-dm/commit/63453b90049cef10309f254c35d8a33e1e6552ba

It shouldn't be a problem to put some u64 properties and read them back.

Karthik: Can you please take a look at it?

Thanks,
Michal