[U-Boot] [PATCH v2 8/9] spl: Introduce SPL_DM_GPIO Kconfig define

[Lukasz Majewski]

On Tue, 17 Sep 2019 14:19:33 -0500
Adam Ford <aford173 at gmail.com> wrote:

> On Tue, Sep 17, 2019 at 1:34 PM Simon Glass <sjg at chromium.org> wrote:
> >
> > Hi Lukasz,
> >
> > On Tue, 17 Sep 2019 at 00:22, Lukasz Majewski <lukma at denx.de>
> > wrote:  
> > >
> > > Hi Simon,
> > >  
> > > > On Sun, 18 Aug 2019 at 19:30, Peng Fan <peng.fan at nxp.com>
> > > > wrote:  
> > > > >  
> > > > > > Subject: [PATCH v2 8/9] spl: Introduce SPL_DM_GPIO Kconfig
> > > > > > define
> > > > > >
> > > > > > This define indicates if DM_GPIO shall be supported in SPL.
> > > > > > This allows proper operation of DM converted GPIO drivers
> > > > > > in SPL, which use #if !CONFIG_IS_ENABLED(DM_GPIO) to also
> > > > > > support not yet DM/DTS converted boards.
> > > > > >  
> 
> Many of the drivers list the SPL_DM options under their respective
> heading.  For example, SPL_DM_USB is under the USB menu right next to
> the option to select CONFIG_DM_USB.
> If we're going to add the option to separate DM_GPIO from SPL_DM_GPIO,
> I would suggest following that pattern and place it in the GPIO menu
> so they are next to each other and make the dependency obvious.

For the current patch I've followed the pattern and added SPL_DM_GPIO
to the "spl" submenu of menuconfig.

And as I've written in the other mail - I think that SPL_DM_GPIO shall
depend on DM_GPIO.

Considering the above - shall I place SPL_DM_GPIO next to DM_GPIO
section or to the "spl" submenu?

> 
> adam
> 
> > > > > > Signed-off-by: Lukasz Majewski <lukma at denx.de>
> > > > > > ---
> > > > > >
> > > > > > Changes in v2:
> > > > > > - New patch
> > > > > >
> > > > > >  common/spl/Kconfig | 6 ++++++
> > > > > >  1 file changed, 6 insertions(+)
> > > > > >  
> > > >
> > > > Reviewed-by: Simon Glass <sjg at chromium.org>
> > > >
> > > > But how about adding && DM_GPIO as well to that depends clause?
> > > >  
> > >
> > > I think that they shall be a separate Kconfig options. Please
> > > imagine that one have board with SPL GPIO support, but not in
> > > U-Boot proper.  
> >
> > Do we really want to support that? It seems a bit odd to me.
> >
> > Most of the DM SPL configs assume/requiree you have U-Boot proper
> > enabled.
> >
> > Regards,
> > Simon
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot at lists.denx.de
> > https://lists.denx.de/listinfo/u-boot  



Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190917/86522ac1/attachment.sig>