[U-Boot] [PATCH 2/2] rsa: Return immediately if required-key verification fails

Philippe Reynes philippe.reynes at softathome.com
Wed Sep 18 14:04:54 UTC 2019

From: Daniele Alessandrelli <daniele.alessandrelli at gmail.com>

Currently, if image verification with a required key fails, rsa_verify()
code tries to find another key to verify the FIT image. This however, is
not the intended behavior as the documentation says that required keys
"must be verified for the image / configuration to be considered valid".

This patch fixes the issue by making rsa_verify() return immediately if
the verification of a required key fails.

Signed-off-by: Daniele Alessandrelli <daniele.alessandrelli at gmail.com>
 lib/rsa/rsa-verify.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lib/rsa/rsa-verify.c b/lib/rsa/rsa-verify.c
index 287fcc4..82dc513 100644
--- a/lib/rsa/rsa-verify.c
+++ b/lib/rsa/rsa-verify.c
@@ -437,8 +437,7 @@ int rsa_verify(struct image_sign_info *info,
 	if (info->required_keynode != -1) {
 		ret = rsa_verify_with_keynode(info, hash, sig, sig_len,
-		if (!ret)
-			return ret;
+		return ret;
 	/* Look for a key that matches our hint */

More information about the U-Boot mailing list