[U-Boot] [PATCH 3/7] cmd: bootimg: Add bootimg command

[Igor Opaniuk]

Hi Simon,

On Fri, Sep 20, 2019 at 8:45 PM Simon Glass <sjg at chromium.org> wrote:
>
> Hi,
>
> On Thu, 19 Sep 2019 at 12:28, Sam Protsenko <semen.protsenko at linaro.org> wrote:
> >
> > This command can be used to extract fields and image payloads from
> > Android Boot Image. It can be used for example to implement boot flow
> > where dtb is taken from boot.img (as v2 incorporated dtb inside of
> > boot.img). Using this command, one can obtain needed dtb file from
> > boot.img in scripting manner, and then apply needed dtbo's (from "dtbo"
> > partition) on top of that, providing then the resulting image to bootm
> > command in order to boot the Android.
> >
> > Also right now this command has the sub-command to get an address and
> > size of recovery dtbo from recovery image. It can be further parsed using
> > 'dtimg' command and merged into dtb file (for non-A/B devices only, see
> > [1,2] for details).
> >
> > [1] https://source.android.com/devices/bootloader/boot-image-header
> > [2] https://source.android.com/devices/architecture/dto/partitions
> >
> > Signed-off-by: Sam Protsenko <semen.protsenko at linaro.org>
> > ---
> >  cmd/Kconfig   |   8 +++
> >  cmd/Makefile  |   1 +
> >  cmd/bootimg.c | 177 ++++++++++++++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 186 insertions(+)
> >  create mode 100644 cmd/bootimg.c
>
>
> Shouldn't this be a subcommand of avb?

I think there is some misunderstanding here, as avb
is used only for signature verification/roll-back protection, other
aspects of booting Android (parsing android boot image) are
handled by other commands (for instance, bootm).

Howewer, I think (IMHO) that `bootimg` isn't a good choice for the
command name , which major functionality is manipulating
dtb/dtbos.

>
> Regards,
> Simon



-- 
Best regards - Freundliche Grüsse - Meilleures salutations

Igor Opaniuk

mailto: igor.opaniuk at gmail.com
skype: igor.opanyuk
+380 (93) 836 40 67
http://ua.linkedin.com/in/iopaniuk