[U-Boot] armv7: ls102xa: Fix endianness of SCFG_SPARECR8

Priyanka Jain priyanka.jain at nxp.com
Wed Sep 25 05:16:06 UTC 2019

>-----Original Message-----
>From: U-Boot <u-boot-bounces at lists.denx.de> On Behalf Of Biwen Li
>Sent: Monday, September 16, 2019 1:31 PM
>To: albert.u.boot at aribaud.net; Ran Wang <ran.wang_1 at nxp.com>; York Sun
><york.sun at nxp.com>
>Cc: u-boot at lists.denx.de
>Subject: [U-Boot] armv7: ls102xa: Fix endianness of SCFG_SPARECR8
Fix endianness means fixing endianness but here you are correcting it
May be subject can be updated to something like
"armv7: ls102xa: Update endianness of SCFG_SPARECR8 read"
>The patch fixes endianness of SCFG_SPARECR8 register
Please update description to something like 
"Correct endianness of SCFG_SPARECR8 register read
in_le32 -> in_be32"

>Signed-off-by: Biwen Li <biwen.li at nxp.com>
> arch/arm/cpu/armv7/ls102xa/ls102xa_psci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>diff --git a/arch/arm/cpu/armv7/ls102xa/ls102xa_psci.c
>index bb169aaaf4..00b6ad48ce 100644
>--- a/arch/arm/cpu/armv7/ls102xa/ls102xa_psci.c
>+++ b/arch/arm/cpu/armv7/ls102xa/ls102xa_psci.c
>@@ -72,7 +72,7 @@ static void __secure ls1_deepsleep_irq_cfg(void)
> 	 * returns zero, so its value is saved to a scrachpad register to be
> 	 * read, that is why we don't read it from register ippdexpcr1 itself.
> 	 */
>-	ippdexpcr1 = in_le32(&scfg->sparecr[7]);
>+	ippdexpcr1 = in_be32(&scfg->sparecr[7]);
> 	out_be32(&rcpm->ippdexpcr1, ippdexpcr1);
> 	if (ippdexpcr0 & RCPM_IPPDEXPCR0_ETSEC)
>U-Boot mailing list
>U-Boot at lists.denx.de

More information about the U-Boot mailing list