[U-Boot] [PATCH RFT 0/3] spi-nor: spi-nor-ids: Fix 4 Byte addressing for n25q256 and n25q512*

[Vignesh Raghavendra]

On 24/09/19 10:53 PM, Eugeniy Paltsev wrote:
> Hi Vignesh,
> 
> I've check this patches on top of 31e086e460f.
> The read/write/erase seems to work. 
> 
> However, as I can see 'sf protect lock' doesn't work - it finish successfully but the area remains unlocked.

Did you verify that area is indeed unlocked by writing data and then reading it back? 
I was able to find a board with mt25qu512a which is same as n25q512a in terms of locking
I see it works fine:

=> sf probe
SF: Detected n25q512a with page size 256 Bytes, erase size 4 KiB, total 64 MiB
=> sf protect lock 0 0x4000000;  echo $? 
0
=> sf write 0x82000000 0x3FF0000 0x100   
device 0 offset 0x3ff0000, size 0x100
SF: 256 bytes @ 0x3ff0000 Written: ERROR -5

If you still see failures wrt locking, could you provide debug logs from 
spi_mem_exec_op() (in drivers/spi/spi-mem.c) just like last time? 


Regards
Vignesh

> As I remember It worked with old u-boot spi-nor code, but I need to check it.
> 
> ---
>  Eugeniy Paltsev
> 
> 
> ________________________________________
> From: Vignesh Raghavendra <vigneshr at ti.com>
> Sent: Tuesday, September 24, 2019 08:56
> To: Jagan Teki; Eugeniy Paltsev; Ashish Kumar; Simon Goldschmidt
> Cc: Vignesh Raghavendra; u-boot at lists.denx.de; Tom Rini; Alexey Brodkin
> Subject: [PATCH RFT 0/3] spi-nor: spi-nor-ids: Fix 4 Byte addressing for n25q256 and n25q512*
> 
> This series removes SPI_NOR_4B_OPCODES flags from legacy variants of
> n25q256* and n25q512* and adds entries for newer variants of those
> flashes that support 4 Byte opcodes.
> 
> I don't have the flash devices. So its only compile tested.
> 
> Ashish, Simon,
> 
> I would greatly appreciate if you could test these patches and make sure
> 4 Byte opcodes are being used. (Probably by enabling/adding prints to
> cmd->opcode in spi_mem_exec_op() in drivers/spi/spi-mem.c
> 
> Euginey,
> 
> Could you test this series on top of latest u-boot master and confirm
> that your test cases still work?
> 
> Regards
> Vignesh
> 
> Vignesh Raghavendra (3):
>   spi-nor: spi-nor-ids: Disable SPI_NOR_4B_OPCODES for n25q512* and
>     n25q256*
>   spi-nor: spi-nor-ids: Rename mt25qu512a entry
>   spi-nor: spi-nor-ids: Add entries for newer variants of n25q256* and
>     n25q512*
> 
>  drivers/mtd/spi/spi-nor-ids.c | 13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)
> 
> --
> 2.23.0
> 

-- 
Regards
Vignesh