[U-Boot] [PATCH 2/2] arm64: zynqmp: Define default SYS_PROMPT

[Michal Simek]

On 25. 09. 19 13:03, Luca Ceresoli wrote:
> Hi Michal,
> 
> On 25/09/19 12:38, Michal Simek wrote:
>> All boards are using the same prompt that's why add it as default value to
>> Kconfig to simplify defconfigs.
>>
>> Signed-off-by: Michal Simek <michal.simek at xilinx.com>
>> ---
>>
>>  cmd/Kconfig                                                    | 1 +
>>  configs/avnet_ultra96_rev1_defconfig                           | 1 -
>>  configs/avnet_ultrazedev_cc_v1_0_ultrazedev_som_v1_0_defconfig | 1 -
>>  configs/xilinx_zynqmp_a2197_g_revA_defconfig                   | 1 -
>>  configs/xilinx_zynqmp_a2197_m_revA_defconfig                   | 1 -
>>  configs/xilinx_zynqmp_a2197_p_revA_defconfig                   | 1 -
>>  configs/xilinx_zynqmp_a2197_revA_defconfig                     | 1 -
>>  configs/xilinx_zynqmp_mini_defconfig                           | 1 -
>>  configs/xilinx_zynqmp_mini_emmc0_defconfig                     | 1 -
>>  configs/xilinx_zynqmp_mini_emmc1_defconfig                     | 1 -
>>  configs/xilinx_zynqmp_mini_nand_defconfig                      | 1 -
>>  configs/xilinx_zynqmp_mini_qspi_defconfig                      | 1 -
>>  configs/xilinx_zynqmp_zc1232_revA_defconfig                    | 1 -
>>  configs/xilinx_zynqmp_zc1254_revA_defconfig                    | 1 -
>>  configs/xilinx_zynqmp_zc1751_xm015_dc1_defconfig               | 1 -
>>  configs/xilinx_zynqmp_zc1751_xm016_dc2_defconfig               | 1 -
>>  configs/xilinx_zynqmp_zc1751_xm017_dc3_defconfig               | 1 -
>>  configs/xilinx_zynqmp_zc1751_xm018_dc4_defconfig               | 1 -
>>  configs/xilinx_zynqmp_zc1751_xm019_dc5_defconfig               | 1 -
>>  configs/xilinx_zynqmp_zcu100_revC_defconfig                    | 1 -
>>  configs/xilinx_zynqmp_zcu102_rev1_0_defconfig                  | 1 -
>>  configs/xilinx_zynqmp_zcu102_revA_defconfig                    | 1 -
>>  configs/xilinx_zynqmp_zcu102_revB_defconfig                    | 1 -
>>  configs/xilinx_zynqmp_zcu104_revA_defconfig                    | 1 -
>>  configs/xilinx_zynqmp_zcu104_revC_defconfig                    | 1 -
>>  configs/xilinx_zynqmp_zcu106_revA_defconfig                    | 1 -
>>  configs/xilinx_zynqmp_zcu111_revA_defconfig                    | 1 -
>>  configs/xilinx_zynqmp_zcu1275_revA_defconfig                   | 1 -
>>  configs/xilinx_zynqmp_zcu1275_revB_defconfig                   | 1 -
>>  29 files changed, 1 insertion(+), 28 deletions(-)
>>
>> diff --git a/cmd/Kconfig b/cmd/Kconfig
>> index ab65f87999dc..65360a69beb6 100644
>> --- a/cmd/Kconfig
>> +++ b/cmd/Kconfig
>> @@ -49,6 +49,7 @@ config SYS_LONGHELP
>>  config SYS_PROMPT
>>  	string "Shell prompt"
>>  	default "Zynq> " if ARCH_ZYNQ
>> +	default "ZynqMP> " if ARCH_ZYNQMP
>>  	default "=> "
> 
> Generally speaking, why do we need a per-machine prompt at all?
> "=> " ought be enough for everybody, nope?
> 
> However to maintain backward compatibility with whatever expects those
> prompts this patch is a good cleanup anyway:
> 
> Reviewed-by: Luca Ceresoli <luca at lucaceresoli.net>

Lava for example is looking for certain string in prompt that's why we
should keep backward compatibility as you mentioned.

M