[U-Boot] [PATCH v2 2/4] libfdt: return correct value if #size-cells property is not present

Simon Glass sjg at chromium.org
Fri Sep 27 01:48:59 UTC 2019


On Tue, 17 Sep 2019 at 09:52, Simon Glass <sjg at chromium.org> wrote:
>
> Hi Matthias,
>
> On Tue, 17 Sep 2019 at 00:29, Matthias Brugger <mbrugger at suse.com> wrote:
> >
> > Hi Simon,
> >
> > On 17/09/2019 07:48, Simon Glass wrote:
> > > Hi,
> > >
> > > On Thu, 5 Sep 2019 at 02:49, <matthias.bgg at kernel.org> wrote:
> > >>
> > >> From: Matthias Brugger <mbrugger at suse.com>
> > >>
> > >> According to the device tree specification, the default value for

There seems to be something missing here/...

> > >> was not present.
> > >>
> > >> This patch also makes fdt_address_cells() and fdt_size_cells() conform
> > >> to the behaviour documented in libfdt.h. The defaults are only returned
> > >> if fdt_getprop() returns -FDT_ERR_NOTFOUND, otherwise the actual error
> > >> is returned.
> > >>
> > >> This is based on upstream commit:
> > >> aa7254d ("libfdt: return correct value if #size-cells property is not present")
> > >> but misses the test case part, as we don't implement them in U-Boot.
> > >>
> > >> Signed-off-by: Matthias Brugger <mbrugger at suse.com>
> > >
> > > This is v2 but I don't see a change log?
> > >
> >
> > I put the changelog into the cover letter:
> > https://patchwork.ozlabs.org/cover/1158304/
> >
> > From your email I understand that you prefer a patch by patch changelog, correct?
>
> Both is best. If you use patman it does this for you.

Reviewed-by: Simon Glass <sjg at chromium.org>

Regards,
Simon


More information about the U-Boot mailing list