[U-Boot] [EXT] Re: [RFC 1/3] scsi: ata: Add DM SCSI interface to support None AHCI sata driver

[Stefan Roese]

Hi Peng,

On 30.09.19 04:42, Peng Ma wrote:
> Hi Stefan,
> 
> Thanks for your opinion.
> 
>> -----Original Message-----
>> From: Stefan Roese <sr at denx.de>
>> Sent: 2019年9月29日 19:46
>> To: Peng Ma <peng.ma at nxp.com>; sjg at chromium.org; Prabhakar X
>> <prabhakar.kushwaha at nxp.com>; jagan at openedev.com;
>> bmeng.cn at gmail.com; Andy Tang <andy.tang at nxp.com>
>> Cc: michal.simek at xilinx.com; andre.przywara at arm.com; smoch at web.de;
>> u-boot at lists.denx.de; Robert Hancock <hancock at sedsystems.ca>
>> Subject: [EXT] Re: [RFC 1/3] scsi: ata: Add DM SCSI interface to support None
>> AHCI sata driver
>>
>> Caution: EXT Email
>>
>> Hi Peng,
>>
>> On 25.09.19 11:54, Peng Ma wrote:
>>> In driver/ata. If the sata driver support AHCI mode, there will
>>> provides a complete set of SCSI interface. If the sata is not support
>>> AHCI
>>> mode(NONE_AHCI) there will not provides the SCSI interface.
>>>
>>> This patch is to support SCSI interface for None AHCI sata such as
>>> fsl_sata.c sil_sata.c etc.
>>>
>>> Signed-off-by: Peng Ma <peng.ma at nxp.com>
>>> ---
>>>    drivers/ata/Kconfig      |  17 +++-
>>>    drivers/ata/Makefile     |   2 +
>>>    drivers/ata/ata-uclass.c |  16 ++++
>>>    drivers/ata/ata.c        | 244
>> +++++++++++++++++++++++++++++++++++++++++++++++
>>>    drivers/ata/sata.c       |   2 +-
>>>    drivers/ata/scsi_ata.h   |  43 +++++++++
>>>    include/dm/uclass-id.h   |   1 +
>>>    7 files changed, 323 insertions(+), 2 deletions(-)
>>>    create mode 100644 drivers/ata/ata-uclass.c
>>>    create mode 100644 drivers/ata/ata.c
>>>    create mode 100644 drivers/ata/scsi_ata.h
>>
>> Please take a look at commit 0506620f4f49 ("sata: sata_mv: Add DM support
>> to enable CONFIG_BLK usage"). Perhaps this is a way to migrate these drivers
>> to DM / BLK as well.
>>
> [Peng Ma] I saw This changed is not support SCSI command.
>> BTW: I agree with Robert, that SCSI is a bit misleading here. We are not using
>> the SCSI commands on the boards with this Marvell (non-AHCI) SATA driver.
>> The SATA command is more appropriate in this case in my eyes.
>>
> [Peng Ma] OK, you mean There is no need to support SCSI command for Non-AHCI
> driver? We still use SATA command for Non-AHCI driver here?

There is no need for the "scsi" command for (S)ATA drivers (AHCI or
non-AHCI). The only reason to support the "scsi" command that I
can think of, is compatibility. So if you need to support old env
scripts that use the "scsi" cmd. As mentioned before, we are not
using the "scsi" command at all with this non-AHCI driver.

Thanks,
Stefan