[PATCH 3/3] ARM: tegra: p2371-2180: add I2C nodes to DT

[Tom Warren]

-----Original Message-----
From: Peter Robinson <pbrobinson at gmail.com> 
Sent: Tuesday, March 31, 2020 3:54 AM
To: tomcwarren3959 at gmail.com
Cc: u-boot at lists.denx.de; Stephen Warren <swarren at nvidia.com>; Thierry Reding <treding at nvidia.com>; Jonathan Hunter <jonathanh at nvidia.com>; Tom Warren <TWarren at nvidia.com>; Vishruth Jain <vishruthj at nvidia.com>
Subject: Re: [PATCH 3/3] ARM: tegra: p2371-2180: add I2C nodes to DT

External email: Use caution opening links or attachments


> From: Stephen Warren <swarren at nvidia.com>
>
> This adds to the DT the I2C controllers that connect to the board ID 
> EEPROM, camera board EEPROM, etc. With this change, you can now probe 
> all I2C devices on a TX1 board.
>
> Signed-off-by: Tom Warren <twarren at nvidia.com>
> ---
>  arch/arm/dts/tegra210-p2371-2180.dts | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm/dts/tegra210-p2371-2180.dts 
> b/arch/arm/dts/tegra210-p2371-2180.dts
> index c2f497c..d982b5f 100644
> --- a/arch/arm/dts/tegra210-p2371-2180.dts
> +++ b/arch/arm/dts/tegra210-p2371-2180.dts
> @@ -12,6 +12,9 @@
>
>         aliases {
>                 i2c0 = "/i2c at 7000d000";
> +               i2c2 = "/i2c at 7000c400";
> +               i2c3 = "/i2c at 7000c500";
> +               i2c5 = "/i2c at 546c0c00";

I don't think this is correct, it doesn't show up in U-Boot with the "i2c bus" command where the others do, looking in the tegra210.dtsi it looks like it should be i2c at 546c0000?
[Tom] That I2C address is working in downstream (L4T) TX1 U-Boot.  The VI_I2C controller is a little weird, it's normal I2C registers are offset from base by 0xC00.  A different driver is needed, but I haven't posted it yet upstream.  I should probably drop if from the DTS for now until I post the VI_I2C driver.

--nvpublic

>                 mmc0 = "/sdhci at 700b0600";
>                 mmc1 = "/sdhci at 700b0000";
>                 usb0 = "/usb at 7d000000"; @@ -33,6 +36,11 @@
>                 };
>         };
>
> +       i2c at 546c0c00 {
> +               status = "okay";
> +               clock-frequency = <400000>;
> +       };
> +
>         padctl at 7009f000 {
>                 pinctrl-0 = <&padctl_default>;
>                 pinctrl-names = "default"; @@ -85,6 +93,16 @@
>                 non-removable;
>         };
>
> +       i2c at 7000c400 {
> +               status = "okay";
> +               clock-frequency = <400000>;
> +       };
> +
> +       i2c at 7000c500 {
> +               status = "okay";
> +               clock-frequency = <400000>;
> +       };
> +
>         i2c at 7000d000 {
>                 status = "okay";
>                 clock-frequency = <400000>;
> --
> 1.8.2.1.610.g562af5b
>
>
> ----------------------------------------------------------------------
> ------------- This email message is for the sole use of the intended 
> recipient(s) and may contain confidential information.  Any 
> unauthorized review, use, disclosure or distribution is prohibited.  
> If you are not the intended recipient, please contact the sender by 
> reply email and destroy all copies of the original message.
> ----------------------------------------------------------------------
> -------------